[postgis-tickets] [PostGIS] #4334: Can't upgrade with a view based on ST_AsMVTGeom

[PostGIS]

#4334: Can't upgrade with a view based on ST_AsMVTGeom
------------------------------------+---------------------------
  Reporter:  Algunenano             |      Owner:  Algunenano
      Type:  defect                 |     Status:  new
  Priority:  high                   |  Milestone:  PostGIS 3.0.0
 Component:  build/upgrade/install  |    Version:  2.4.x
Resolution:                         |   Keywords:
------------------------------------+---------------------------

Comment (by Algunenano):

 I plan to clean this file (`postgis/postgis_drop_before.sql`) a bit,
 document things as much as possible there and try to drop functions /
 aggregates that continue to exists (renamed parameters or added defaults).

 The fist step is to review the drops and check when and why are there:


 - `addgeometrycolumn`: A signature was dropped and it's not substituted by
 another. Keeping the DROP is fine.

 - `ST_MakeEnvelope`: A new signature was added `(float8, float8, float8,
 float8)` during the 2.0 development, but it was replaced by a default
 `(float8, float8, float8, float8, int)` which already existed. I'm
 dropping the drop (o_O) since I don't think nobody is going to upgrade
 from 2.0.0dev.

 - `ST_AsX3D`: Signature changed (the old one is no longer valid). Keeping
 the DROP is fine.

 - `UpdateGeometrySRID`: Changed parameter name. Needs to be dropped
 conditionally (only if the params match the old signature, not the new
 one).

 - Operators changed between 2.0 and 2.1: They are being renamed manually.
 Keeping them from now.
   - `geometry_gist_sel_2d` -> `gserialized_gist_sel_2d`
   - `geometry_gist_joinsel_2d` -> `gserialized_gist_joinsel_2d`
   - `geography_gist_selectivity` -> `gserialized_gist_sel_nd`.
   - `geography_gist_join_selectivity` -> `gserialized_gist_joinsel_nd`

 - `ST_AsLatLonText`: When from multiple functions to one with default
 args. One signature can be dropped but the other has to be dropped
 conditionally.

 - `ST_AsTWKB`: Same as ST_AsLatLonText.

 - `_st_linecrossingdirection` / `ST_LineCrossingDirection` /
 `_st_orderingequals`/ `st_orderingequals`: Named to unnamed. Needs to be
 dropped conditionally.

 - `st_askml`: Changed with defaults, but these signatures don't conflict
 with the current one. Simple DROP can be kept.

 - `st_buffer`: Changed with defaults, but the signature doesn't conflict
 with the current one. Simple DROP can be kept.

 - `ST_AsMVT` / `ST_AsMVTGeom` / `ST_AsGeobuf` / `pgis_asgeobuf_transfn` /
 `pgis_asmvt_transfn`: Signatures were changed during dev / RC development
 during 2.4.0. Dropping the DROPS as they shouldn't be necessary any
 longer.

 - `ST_CurveToLine`: Changed with defaults, but these signatures don't
 conflict with the current one. Simple DROP can be kept.

 - `geometry_columns VIEW`: We are already using `CREATE OR REPLACE VIEW`
 so we can drop this.

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4334#comment:13>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.