[postgis-tickets] [PostGIS] #4501: postgis_tiger_geocoder extension needs super_user=false

[PostGIS]

#4501: postgis_tiger_geocoder extension needs super_user=false
----------------------------+---------------------------
 Reporter:  robe            |      Owner:  robe
     Type:  defect          |     Status:  new
 Priority:  blocker         |  Milestone:  PostGIS 2.5.4
Component:  tiger geocoder  |    Version:  2.5.x
 Keywords:                  |
----------------------------+---------------------------
 I had assumed that extensions could be installed by non-superusers if they
 are pure sql/plpsql.  evidentally in extension control file it also needs
 to be marked as such as noted by RhodiumToad on IRC


 {{{
 00:30:15        robe2:  RhodiumToad but if postgis_tiger_geocoder is all
 plpgsql shouldn't that be allowed?
 00:30:59        RhodiumToad:    ... is it?
 00:32:32        RhodiumToad:    the extension control file is responsible
 for having superuser=false if the extension is successfully installable by
 non-superusers
 00:37:23        robe2:  yes it's all sql and plpgsql
 00:38:24        robe2:  it relies on PostGIS but it has no C functions
 just uses the postgis geometry type
 00:45:56        localhorse:     RhodiumToad, robe2: is heroku's whitelist
 visible somewhere?
 00:56:21        RhodiumToad:    robe2: does it have a superuser=false
 declaration in the control file?
 00:56:30        RhodiumToad:    localhorse: presumably in their docs
 01:07:45        robe2:  no
 01:07:50        robe2:  should I add one?
 01:08:32        RhodiumToad:    if all the commands in the extension sql
 file can be executed by a non-superuser, even in the upgrade case (i.e. no
 hacking on system catalogs allowed), then yes
 01:08:45        robe2:  okay thanks :)
 01:08:46        RhodiumToad:    if not then no
 01:08:58        RhodiumToad:    test it out of course
 01:09:19        robe2:  yah no crazy hacking of catalog files is done
 everything thru just sql or pgsql and no direct update of system catalogs
 }}}

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4501>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.