[postgis-tickets] [PostGIS] #4814: GEOS roundtrip conversion drops empty components

[PostGIS]

#4814: GEOS roundtrip conversion drops empty components
-----------------------+---------------------------
  Reporter:  strk      |      Owner:  pramsey
      Type:  defect    |     Status:  reopened
  Priority:  critical  |  Milestone:  PostGIS 3.1.0
 Component:  postgis   |    Version:  2.5.x
Resolution:            |   Keywords:
-----------------------+---------------------------

Comment (by strk):

 Looks like being a PostGIS, not GEOS, issue:

 {{{
 ==12253== Invalid free() / delete / delete[] / realloc()
 ==12253==    at 0x4C32D3B: free (in /usr/lib/valgrind/vgpreload_memcheck-
 amd64-linux.so)
 ==12253==    by 0x18D89A58: lwcollection_make_geos_friendly
 (lwgeom_geos_clean.c:345)
 ==12253==    by 0x18D8A47A: lwgeom_make_valid (lwgeom_geos_clean.c:906)
 ==12253==    by 0x18CAC1D1: ST_MakeValid (lwgeom_geos_clean.c:71)
 ==12253==    by 0x348E55: ??? (in /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x3F02EB: ??? (in /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x3F1BB0: ??? (in /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x3F25D9: ??? (in /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x393960: expression_tree_mutator (in
 /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x3F2401: ??? (in /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x39405A: expression_tree_mutator (in
 /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x3F2401: ??? (in /usr/lib/postgresql/10/bin/postgres)
 ==12253==  Address 0x18908018 is 104 bytes inside a block of size 8,192
 alloc'd
 ==12253==    at 0x4C31B0F: malloc (in /usr/lib/valgrind
 /vgpreload_memcheck-amd64-linux.so)
 ==12253==    by 0x5BA367: ??? (in /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x5BF7AD: palloc (in /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x18D65A49: lwcollection_from_gserialized2_buffer
 (gserialized2.c:1413)
 ==12253==    by 0x18D65A49: lwgeom_from_gserialized2_buffer
 (gserialized2.c:1492)
 ==12253==    by 0x18D673C2: lwgeom_from_gserialized2 (gserialized2.c:1529)
 ==12253==    by 0x18CAC1BD: ST_MakeValid (lwgeom_geos_clean.c:49)
 ==12253==    by 0x348E55: ??? (in /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x3F02EB: ??? (in /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x3F1BB0: ??? (in /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x3F25D9: ??? (in /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x393960: expression_tree_mutator (in
 /usr/lib/postgresql/10/bin/postgres)
 ==12253==    by 0x3F2401: ??? (in /usr/lib/postgresql/10/bin/postgres)
 }}}

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4814#comment:12>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.