[postgis-tickets] [PostGIS] #5090: configure --with-protobuf-lib / --with-protobufdir broken

[PostGIS]

#5090: configure --with-protobuf-lib / --with-protobufdir broken
-----------------------------------+---------------------------
 Reporter:  tbussmann              |      Owner:  strk
     Type:  defect                 |     Status:  new
 Priority:  medium                 |  Milestone:  PostGIS 3.2.1
Component:  build/upgrade/install  |    Version:  master
 Keywords:                         |
-----------------------------------+---------------------------
 Currently it is not possible to compile PostGIS with protobuf-c by
 specifying the path to the library using `--with-protobuf-lib=` or
 `--with-protobufdir=`, only if the installation can be found by `pkg-
 config` it can be overridden by `PROTOBUFC_LIBS`. Effectively, the
 `-lprotobuf-c` is missing in LDFLAGS.

 The first option broke by commit [6eeee128815/git] as an attempt to fix
 #4964. Part of this change broke building ''with'' `pkg-config` as its
 output was now overwritten and thus the `-L` went missing which resulted
 in #4977. That again was fixed by an attempt to roll back the first change
 by [86a8a5979/git]. Unfortunately that finally broke `--with-protobufdir`
 and resulted in the current situation.

 To fix, we need to add ` -lprotobuf-c` back to line
 source:git/configure.ac at 98c1ed85#L1031 and
 source:git/configure.ac at 98c1ed85#L1043.

 For the original issue, #4964 I can imagine to further develop the idea
 from the first attempt but guard that a bit by replacing
 source:git/configure.ac at 98c1ed85#L1062 with something like that:

 {{{
         [if test "x$PROTOBUF_LDFLAGS" = "x"; then
                 PROTOBUF_LDFLAGS="-lprotobuf-c"
         fi],
 }}}

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5090>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.