[postgis-tickets] [PostGIS] #5090: configure --with-protobuf-lib / --with-protobufdir broken

[PostGIS]

#5090: configure --with-protobuf-lib / --with-protobufdir broken
------------------------------------+---------------------------
  Reporter:  tbussmann              |      Owner:  strk
      Type:  defect                 |     Status:  closed
  Priority:  medium                 |  Milestone:  PostGIS 3.2.1
 Component:  build/upgrade/install  |    Version:  master
Resolution:  fixed                  |   Keywords:
------------------------------------+---------------------------

Comment (by tbussmann):

 thanks for applying the patches!

 > Unfortunately I'm not sure how to test this corner case.

 Something among the following may work:
 * configure postgis with the {{{--with-protobufdir}}} or {{{--with-
 protobuf-lib}}}/{{{--with-protobuf-inc}}} set to your {{{protobuf-c}}}
 installation
 * without the first patch, the configure will be successful but the build
 will fail.
 * apply the first patch, repeat configure, verify that it now builds

 For the second patch (original intention of #4964):
 * remove the {{{libprotobuf-c.pc}}} from your {{{pkgconfig}}} directory
 * make sure the {{{protobuf-c}}} library can be found in your default lib
 / include paths
 * configure postgis w/o any protbuf related parameters.
 * without the second patch, the configure will be successful but the build
 will fail.
 * apply the second patch, repeat configure, verify that it now builds

 Make sure this does not interfere with pkg-config builds (#4977)
 * move the {{{libprotobuf-c.pc}}} file back to your {{{pkgconfig}}}
 directory
 * configure postgis w/o any protbuf related parameters.
 * with the patches applied, configure and build should still be successful
 (I think, that was already verified by the CI)

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5090#comment:6>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.