[postgis-tickets] [SCM] PostGIS branch stable-3.3 updated. 3.3.4-15-g343e2d418

[git at osgeo.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "PostGIS".

The branch, stable-3.3 has been updated
       via  343e2d4189b50e0691eb981e674389a8da339eb5 (commit)
      from  ae2701ba9aae9566c3ba32737e8c4b215027c066 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 343e2d4189b50e0691eb981e674389a8da339eb5
Author: Sandro Santilli <strk at kbt.io>
Date:   Mon Sep 25 12:47:52 2023 +0200

    Fix box-filtered validity check of topologies with edge-less faces
    
    Includes regress test.
    References #5548 in stable-3.3 branch (3.3.5dev)

diff --git a/NEWS b/NEWS
index 8be4265ee..3ba338c00 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,8 @@ PostGIS 3.3.5dev
 YYYY/MM/DD
 
 * Bug Fixes and Enhancements *
+ - #5548, Fix box-filtered validity check of topologies with edge-less faces
+          (Sandro Santilli)
  - #5442, [postgis_tiger_geocoder,postgis_topology]
           Database search_path does not do
           what it intends to do (Jelte Fennema)
diff --git a/topology/sql/manage/ValidateTopology.sql.in b/topology/sql/manage/ValidateTopology.sql.in
index 55d89e60e..a63cdfc78 100644
--- a/topology/sql/manage/ValidateTopology.sql.in
+++ b/topology/sql/manage/ValidateTopology.sql.in
@@ -884,6 +884,7 @@ BEGIN
       SELECT right_face FROM edge
     )
   LOOP --{
+    invalid_faces := array_append(invalid_faces, rec.id1);
     retrec.error = 'face without edges';
     retrec.id1 = rec.id1;
     retrec.id2 = NULL;
diff --git a/topology/test/regress/validatetopology.sql b/topology/test/regress/validatetopology.sql
index 2aab5e6b6..8a23aed2e 100644
--- a/topology/test/regress/validatetopology.sql
+++ b/topology/test/regress/validatetopology.sql
@@ -195,5 +195,16 @@ SELECT '#5403.1', * FROM topology.ValidateTopology(
 );
 ROLLBACK;
 
+-- See https://trac.osgeo.org/postgis/ticket/5548
+BEGIN;
+SELECT NULL FROM topology.CreateTopology('t5548');
+SELECT '#5548.0', topology.TopoGeo_addPolygon('t5548',
+  'POLYGON((0 0, 5 10, 10 0,0 0))');
+DELETE FROM t5548.edge;
+DELETE FROM t5548.node;
+SELECT '#5548.1', * FROM topology.ValidateTopology('t5548',
+  ST_MakeEnvelope(2,2,4,4));
+ROLLBACK;
+
 SELECT NULL FROM topology.DropTopology('city_data');
 
diff --git a/topology/test/regress/validatetopology_expected b/topology/test/regress/validatetopology_expected
index b0c954fee..82242d0a4 100644
--- a/topology/test/regress/validatetopology_expected
+++ b/topology/test/regress/validatetopology_expected
@@ -38,3 +38,5 @@
 #5105.edges_count|2
 #5105.faces_count|0
 #5403.0|1
+#5548.0|1
+#5548.1|face without edges|1|

-----------------------------------------------------------------------

Summary of changes:
 NEWS                                            |  2 ++
 topology/sql/manage/ValidateTopology.sql.in     |  1 +
 topology/test/regress/validatetopology.sql      | 11 +++++++++++
 topology/test/regress/validatetopology_expected |  2 ++
 4 files changed, 16 insertions(+)


hooks/post-receive
-- 
PostGIS