[PostGIS] #5683: 32bit test fails on ST_SnapToGrid test
PostGIS
trac at osgeo.org
Thu Mar 14 19:19:48 PDT 2024
#5683: 32bit test fails on ST_SnapToGrid test
----------------------+---------------------------
Reporter: strk | Owner: pramsey
Type: defect | Status: new
Priority: blocker | Milestone: PostGIS 3.5.0
Component: postgis | Version: master
Resolution: | Keywords: regression
----------------------+---------------------------
Comment (by robe):
I was reading strk's notice wrong. I was thinking he was blaming
pramsey's big fat commit of
https://trac.osgeo.org/postgis/changeset/dd88d87cfc3b7b7b7f059171fb090ee4b2db8836/git
No that was the last successful one.
So whatever the cause of this happened after January 14th (after the
above).
Sadly we had a long period of both the test and test32 failing because of
stupid defined but not used notices,
{{{
/builds/postgis/postgis/liblwgeom/profile.h:5:15: error: 'cpu_time_used'
defined but not used [-Werror=unused-variable]
5 | static double cpu_time_used;
| ^~~~~~~~~~~~~
/builds/postgis/postgis/liblwgeom/profile.h:4:28: error: 'end_time'
defined but not used [-Werror=unused-variable]
4 | static clock_t start_time, end_time;
| ^~~~~~~~
/builds/postgis/postgis/liblwgeom/profile.h:4:16: error: 'start_time'
defined but not used [-Werror=unused-variable]
4 | static clock_t start_time, end_time;
}}}
that evidentally we were blissfully ignoring then followed by another
storm, of "Regina is sloppy" errors
{{{
272 | snprintf(errbuf, errbuflen, _("ERROR: column map file
specifies a DBF field name \"%s\" which is longer than 10 characters"),
map->dbffieldnames[curmapsize]);
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/builds/postgis/postgis/loader/shpcommon.h:24:19: note: in definition of
macro '_'
24 | #define _(String) String
| ^~~~~~
/builds/postgis/postgis/loader/shpcommon.c:272:52: note: format string is
defined here
272 | snprintf(errbuf, errbuflen, _("ERROR: column map file
specifies a DBF field name \"%s\" which is longer than 10 characters"),
map->dbffieldnames[curmapsize]);
}}}
which we were also blissfully ignoring.
, then followed by a storm of "What is strk doing with topology?" and why
is he letting all the bots turn red.
Until we finally get to @strk commit which fixes the last of those sloppy
errors
leaving us with a green on 64-bit test and a red test32
https://gitlab.com/postgis/postgis/-/jobs/6292825666
https://gitlab.com/postgis/postgis/-/commit/07a73c0f2c5cb07e33fd64dadd24fac35efdc0a5
So issue is somewhere after January 14th and on or before February 29th.
--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5683#comment:9>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.
More information about the postgis-tickets
mailing list