[postgis-users] Eliminating USE_PG72

[Paul Ramsey]

Greg Stark wrote:
> It seems kind of silly to me to default to only working with old versions of
> PostgreSQL, won't this be wrong for all new users? 

At the time 7.2 index support was added, setting 7.2 indexes to the 
default would have made the default installation broken for all the 
*current* users of postgis (who were necessarily using version 7.1). You 
say potato, I say potato. One way or another, someone is going to have 
to read the README. :)

> It seems doubly silly since
> this is easily fixed to be automatic. This patch is only tested with a couple
> versions of PostgreSQL though:

Thanks for the patch, I have applied it in a modified form to the CVS 
version. Yet another proof that "all bugs are shallow given enough eyes". :)

I am sorely tempted to move the whole 7.2-or-not switch into a macro in 
the .c file and clean up the atrocious mess which is the Makefile. 
Chris, we had a reason not to do this originally, but I have forgotten 
what it was...

P.

-- 
       __
      /
      | Paul Ramsey
      | Refractions Research
      | Email: pramsey at refractions.net
      | Phone: (250) 885-0632
      \_