[postgis-users] 1.3.0 comments from a packaging perspective

[Mark Cave-Ayland]

On Tue, 2007-08-21 at 21:01 -0400, Greg Troxel wrote:
> I am in the midst of updating the postgis package in pkgsrc to 1.3.1.
> 
> templategis has been removed from the build/install targets (r2652) I
> found no NEWS entry about this, or anything in the README.  As a
> packager, should I take this as a hint that templategis is deprecated,
> and binary packages should not include it?  This seems worthy of NEWS as
> a user-visible change in what is installed.

Well, if you actually got template_gis to build in the first place then
you are in the minority ;)

The code for template_gis wasn't really reviewed before commit, and so
contains several debian-only commands which caused it to fail on just
about every other distribution (in particular it tries to write to /etc
which broke every installation as a non-root user). There have been lots
of emails about this on the list, so apologies if you weren't aware of
this.

> I build with -j4 on a dual-processor system (NetBSD/i386, Thinkpad T60).
> The build failed, and restarting it got:
> 
> ===> Building for postgresql81-postgis-1.3.1
> Using GNU make found at /usr/home/gdt/NetBSD-current/pkgsrc/geography/postgresql81-postgis/work/.tools/bin/gmake
> gmake[1]: Entering directory `/usr/home/gdt/NetBSD-current/pkgsrc/geography/postgresql81-postgis/work/postgis-1.3.1'
> /usr/home/gdt/NetBSD-current/pkgsrc/geography/postgresql81-postgis/work/.tools/bin/gmake -C lwgeom 
> gmake[1]: *** read jobs pipe: No such file or directory.  Stop.
> gmake[1]: *** Waiting for unfinished jobs....
> gmake[2]: Entering directory `/usr/home/gdt/NetBSD-current/pkgsrc/geography/postgresql81-postgis/work/postgis-1.3.1/lwgeom'
> gmake[2]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
> gmake[2]: Nothing to be done for `all'.
> gmake[2]: Leaving directory `/usr/home/gdt/NetBSD-current/pkgsrc/geography/postgresql81-postgis/work/postgis-1.3.1/lwgeom'
> gmake[1]: Leaving directory `/usr/home/gdt/NetBSD-current/pkgsrc/geography/postgresql81-postgis/work/postgis-1.3.1'
> gmake: *** [all] Error 2
> *** Error code 2
> 
> Stop.
> make: stopped in /usr/home/gdt/NetBSD-current/pkgsrc/geography/postgresql81-postgis
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/pkgsrc/geography/postgresql81-postgis

Not sure about this - I can't say I've ever built PostGIS in a
multi-threaded fashion...

> There are some warnings (full logs on request):
> 
> lex.yy.c:4023: warning: 'yyunput' defined but not used
> /usr/home/gdt/NetBSD-current/pkgsrc/geography/postgresql81-postgis/work/.buildlink/include/geos_c.h:287: warning: type qualifiers ignored on function return type
> /usr/home/gdt/NetBSD-current/pkgsrc/geography/postgresql81-postgis/work/.buildlink/include/geos_c.h:297: warning: type qualifiers ignored on function return type
> /usr/home/gdt/NetBSD-current/pkgsrc/geography/postgresql81-postgis/work/.buildlink/include/geos_c.h:304: warning: type qualifiers ignored on function return type
> /usr/home/gdt/NetBSD-current/pkgsrc/geography/postgresql81-postgis/work/.buildlink/include/geos_c.h:313: warning: type qualifiers ignored on function return type
> lwgeom_estimate.c:164: warning: array subscript has type 'char'
> shpopen.c:176: warning: 'rcsid' defined but not used
> dbfopen.c:1508: warning: array subscript has type 'char'
> dbfopen.c:1508: warning: array subscript has type 'char'
> dbfopen.c:206: warning: 'rcsid' defined but not used
> shp2pgsql.c:445: warning: array subscript has type 'char'
> shp2pgsql.c:1742: warning: passing argument 2 of 'iconv' from incompatible pointer type
> pgsql2shp.c:2620: warning: array subscript has type 'char'
> pgsql2shp.c:3337: warning: array subscript has type 'char'

The GEOS warnings are known about - unfortunately the code has to be
written in this way to allow PostGIS to build with both GEOS 3 and GEOS
2. The dbfopen.c warning comes from our version of shapelib - I've never
really looked into this in any detail as it comes from an external
source, and the iconv() message I remember seeing here before but never
really explored in detail.


HTH,

Mark.

-- 
ILande - Open Source Consultancy
http://www.ilande.co.uk