[postgis-users] 1.3.3 Pre-Release Notice

[Paragon Corporation]

By the way I'm still testing out my DBF only feature to shp2pgsql in my
tiger load to make sure it works fully and I didn't break something in the
process.  The change was sadly much more invasive than I had hoped. I ended
up having to touch a lot of functions in the shp2pgsql,  so I guess it won't
be able to make it in for this release.

Would anyone be interested in testing it out?  And How should I contribute
the code Paul since I'm a terrible newbie?

The change is as follows
1) If the shp2pgsql can't find a companion shp file, it will display a
warning that there is no shp file and that it will just do an attribute load
and skip creating the geometry column.

2) I also added another switch called  n - which means don't load shape.
Not sure how useful this would be to people, but it is something that I have
needed off and own when I actually don't care about the geometry.

3) I also fixed some typos.

The other issue I noticed with the file, and could just be my editor (which
drove me a bit crazy) is that in some locations, the indentation is off so I
reindented some sections.  Also less of a deal there seems to be a mix of
syntax style -e.g 

if () {

}

Vs.
if (..)
{

}

What is the prefered style?

Thanks,
Regina

 

-----Original Message-----
From: postgis-users-bounces at postgis.refractions.net
[mailto:postgis-users-bounces at postgis.refractions.net] On Behalf Of Paul
Ramsey
Sent: Wednesday, April 09, 2008 12:05 AM
To: PostGIS Users Discussion
Subject: Re: [postgis-users] 1.3.3 Pre-Release Notice

Correct, I changed them all to strcmp(sr_id,"-1"), which should do the
trick.

On Tue, Apr 8, 2008 at 5:51 PM, Paragon Corporation <lr at pcorp.us> wrote:
> By the way I have been looking at that file and wrote up some code to 
> deal  with DBF only situations which I am still testing thru.
>
>  For your info - all those lines contain  sr_id && sr_id != "-1"
>
>  And sr_id is initialized as
>
>  char *sr_id =NULL
>
>  I forgot all my C, but am I mistaken in saying that
>
>  sr_id != "-1"  is not a safe comparison since you are comparing 
> address with  a constanct string "-1"
>
>  Hope that helps,
>  Regina
>
>
>
>  -----Original Message-----
>  From: postgis-users-bounces at postgis.refractions.net
>  [mailto:postgis-users-bounces at postgis.refractions.net] On Behalf Of 
> Paul  Ramsey
>  Sent: Tuesday, April 08, 2008 5:38 PM
>  To: PostGIS Users Discussion
>  Subject: Re: [postgis-users] 1.3.3 Pre-Release Notice
>
>  OK, they should be gone now... btw what compiler are you using, I 
> didn't get  those...
>
>  On Tue, Apr 8, 2008 at 2:22 PM, Mark Cave-Ayland  
> <mark.cave-ayland at siriusit.co.uk> wrote:
>  >
>  > On Monday 07 April 2008 22:12:42 Paul Ramsey wrote:
>  >  > Folks,
>  >  >
>  >  > 1.3.3 is going to be coming out by the end of this week. If you  
> > have  > time, please pull the SVN version and give it a try, to 
> ensure  > we  > haven't left any big bugs in the bin.
>  >  >
>  >  > Thanks!
>  >  >
>  >  > Paul
>  >
>  >  Here's something else we need to look at before release. I see the  
> > following (rather scary) warnings when compiling shp2pgsql:
>  >
>  >  gcc -g -Wall -I.. -DUSE_ICONV -DUSE_VERSION=82
>  >  -DPOSTGIS_VERSION='"1.3.3SVN"'   -c -o shp2pgsql.o shp2pgsql.c
>  >  shp2pgsql.c: In function 'InsertLineString':
>  >  shp2pgsql.c:786: warning: comparison with string literal results 
> in  > unspecified behaviour  >  shp2pgsql.c: In function 
> 'InsertPolygon':
>  >  shp2pgsql.c:1069: warning: comparison with string literal results 
> in  > unspecified behaviour  >  shp2pgsql.c: In function 
> 'InsertPoint':
>  >  shp2pgsql.c:1205: warning: comparison with string literal results 
> in  > unspecified behaviour  >  shp2pgsql.c: In function 
> 'InsertMultiPoint':
>  >  shp2pgsql.c:1243: warning: comparison with string literal results 
> in  > unspecified behaviour  >  >  I'm busy looking at GBT#13, so if 
> anyone else would like to get to  > this  before I do, feel free.
>  >
>  >
>  >  ATB,
>  >
>  >  Mark.
>  >
>  >  --
>  >  Mark Cave-Ayland
>  >  Sirius Corporation - The Open Source Experts  > 
> http://www.siriusit.co.uk  >  T: +44 870 608 0063  >  >  
> _______________________________________________
>  >  postgis-users mailing list
>  >  postgis-users at postgis.refractions.net
>  >  http://postgis.refractions.net/mailman/listinfo/postgis-users
>  >
>  _______________________________________________
>  postgis-users mailing list
>  postgis-users at postgis.refractions.net
>  http://postgis.refractions.net/mailman/listinfo/postgis-users
>
>
>
>  _______________________________________________
>  postgis-users mailing list
>  postgis-users at postgis.refractions.net
>  http://postgis.refractions.net/mailman/listinfo/postgis-users
>
_______________________________________________
postgis-users mailing list
postgis-users at postgis.refractions.net
http://postgis.refractions.net/mailman/listinfo/postgis-users