[PROJ] PROJ 6 testntv2 fails

[Markus Metz]

On Wed, Mar 6, 2019 at 8:38 PM Greg Troxel <gdt at lexort.com> wrote:
>
> Markus Metz <markus.metz.giswork at gmail.com> writes:
>
> > On Wed, Mar 6, 2019 at 6:57 PM Greg Troxel <gdt at lexort.com> wrote:
> >>
> >> Given that the grid files are intended to get better results, it would
> >> be really nice if the tests passed with them, either via fuzz (which
> >> makes sense if both answers are correct) or via having two recorded
> >> acceptable values.
> >
> > I guess the tests are designed to test the numerical stability of the
proj
> > code, for given input data. Therefore it does not matter how accurate
the
> > input data are, what matters is that for the expected input data the
> > expected result must be provided. If the input data are not as expected,
> > the test fails, obviously.
>
> yes, but
>
> > The output line
> > -->
> > Try with NTv2 and NTv1 together ... falls back to NTv1
> > <--
> > looks suspicious, also causing the test failure.
> >
> > README:
> > "The test suite requires that the proj-datumgrid package is installed
> > in `PROJ_LIB`."
> >
> > This should be expanded to note which datumgrid packages should *not* be
> > installed for the tests, or that only the package proj-datumgrid-<X>.<Y>
> > should be installed, but no other datumgrid packages.
>
> This is what's awkward.  Various packaging systems will have different
> approaches.  One is to include all the grids (space is cheap, simple),
> another is to make them separate packages, and another is to not package
> them at all.  Telling people that you can't run proj tests if the other
> package is installed, when really you should have it installed, just
> makes it hard and will make the tests be ignored.

I was reporting as a user compiling proj from source, not as a packager. I
agree that tests must succeed if only the minimum required datum grids are
installed (why are these not included in the proj source code?) and also if
all other datum grids available from https://proj4.org/download.html are
installed. Additional grids e.g. mentioned in
https://proj4.org/resource_files.html#external-resources should not be
considered by the tests.

In short, tests must use expected input and ignore unexpected input in
order to succeed. That's what you suggest, right?

Markus M
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/proj/attachments/20190306/f192ec0a/attachment.html>