[PROJ] PROJ 9.4.1RC1 & PROJ-data 1.18RC1

[Mike Taves]

Thanks for testing and reporting clear feedback. I've added a few
comments inline:

On Tue, 28 May 2024 at 11:36, Greg Troxel via PROJ <proj at lists.osgeo.org> wrote:
>   -- Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY) (Required is at least version "1.8.1")
>   -- Fetching GTest
>   -- PROJ: Configured 'dist' target

There is an error after "Fetching GTest" which is not shown. For the
record, the relevant changes are from:
https://github.com/OSGeo/PROJ/pull/4006

I'm not able to replicate this with various Docker images (it's not
easy to switch off the network). What version of cmake is this with?

>   - proj seems wrong to error out without GTest, given the install docs.

The behaviour should disable tests if the minimum GTest is not
available, showing non-fatal error messages. It should allow it to be
built, without test capabilities.

>   - it's a bug to try to use the network at build time.  I'm not sure
>     what "Fetching GTest" is but it looks like that's what's happening.
>     pkgsrc arranges for proxy variables to prevent this from working.

Is there a general consensus if "tests should not use the network at
build time" is a bug or not? There is a related and undocumented
"RUN_NETWORK_DEPENDENT_TESTS" configuration:
https://github.com/OSGeo/PROJ/blob/3b7a6a9b2e5ca9441cd589f552d64a9ec196678f/test/CMakeLists.txt#L3

Should there be a CMake variable to control if a network should be
available or not?

>   - it doesn't make sense to printing out that GTest was not found
>     (which is fine if optional) and then try to use it.

Agree, but I'll need to sort-out how to replicate this behaviour.

>   - even if the docs are wrong, it should be specified as a test
>     dependency, not a regular build dependency.  Packaging systems are
>     careful to minimize dependencies
>
>   - not really related, but it found nlohmann-json which was not
>     documented as a dependency.   In pkgsrc, as I would expect in every
>     other system (unless they *only* build in chroot) to need, for each
>     possible dependency, to either provide it or to configure it off

Also good suggestions. The docs should be expanded to list the test
dependencies (after the build dependencies). I can sort-out these doc
enhancements.

Are you able to re-test with googletest installed?
https://pkgsrc.se/devel/googletest