From j1 at jimenezshaw.com Mon Jul 6 00:26:47 2026 From: j1 at jimenezshaw.com (Javier Jimenez Shaw) Date: Mon, 6 Jul 2026 09:26:47 +0200 Subject: [PROJ] false positive of cppcheck? Message-ID: After updating my repo to upstream, I get this error https://github.com/jjimenezshaw/PROJ/actions/runs/28773629301/job/85312573467 Cppcheck 2.22 dev Running cppcheck on /home/runner/work/PROJ/PROJ/./scripts/../src... (can be long) /home/runner/work/PROJ/PROJ/src/iso19111/io.cpp:7259,style,knownConditionTrueFalse,Condition '!datumAdded' is always true knownConditionTrueFalse check failed Is it a false positive? In https://github.com/OSGeo/PROJ/actions/runs/28773631888/job/85312581973 the failure is there, but the test is green. Am I missing anything? Thank you Javier -------------- next part -------------- An HTML attachment was scrubbed... URL: From lnicola at dend.ro Mon Jul 6 02:54:03 2026 From: lnicola at dend.ro (=?UTF-8?Q?Lauren=C8=9Biu_Nicola?=) Date: Mon, 06 Jul 2026 12:54:03 +0300 Subject: [PROJ] false positive of cppcheck? In-Reply-To: References: Message-ID: <8d3954dc-2a33-4a90-ad5c-6ee1ab3c3ae1@betaapp.fastmail.com> Hi Javier, It looks like a regression in cppcheck 2.22-dev (2.21 works). I minimized it to: extern bool f(); int main() { bool datumAdded = false; if (f()) { if (f()) return 1; if (f()) datumAdded = true; } if (datumAdded); // style: Condition 'datumAdded' is always false } I wanted to report it, but I honestly don't feel like dealing with their registration process (see what I mean about the OSGeo mantra, strk?). Daniel, please take a look at the snippet above or, if not, create an account for me: lnicola:$2y$10$K2I2FWFyLHMGZh/CYsMaTO4g3N1PzeN37JAo85616xmwMCnb7HiyW Laurentiu On Mon, Jul 6, 2026, at 10:26, Javier Jimenez Shaw via PROJ wrote: > After updating my repo to upstream, I get this error > > https://github.com/jjimenezshaw/PROJ/actions/runs/28773629301/job/85312573467 > > Cppcheck 2.22 dev > Running cppcheck on /home/runner/work/PROJ/PROJ/./scripts/../src... (can be long) > /home/runner/work/PROJ/PROJ/src/iso19111/io.cpp:7259,style,knownConditionTrueFalse,Condition '!datumAdded' is always true > knownConditionTrueFalse check failed > > Is it a false positive? > > In https://github.com/OSGeo/PROJ/actions/runs/28773631888/job/85312581973 the failure is there, but the test is green. > > Am I missing anything? > > Thank you > Javier > _______________________________________________ > PROJ mailing list > PROJ at lists.osgeo.org > https://lists.osgeo.org/mailman/listinfo/proj > -------------- next part -------------- An HTML attachment was scrubbed... URL: From gdt at lexort.com Mon Jul 6 05:38:47 2026 From: gdt at lexort.com (Greg Troxel) Date: Mon, 06 Jul 2026 08:38:47 -0400 Subject: [PROJ] documentation pdf changing content without changing name Message-ID: (Packaging systems expect that a specific download URL will always return the same contents; to have it otherwise looks like an attack.) pkgsrc has had a proj-doc package for a long time. The point is to have the docs locally, and via a package that will get automatically updated. I recently (and belatedly, for no good reason) updated pkgsrc/geography/proj-doc from 9.6 to 9.8. I have been using a URL over multiple versions, adjusted for version numbers: https://proj.org/_/downloads/en/${VERSION}/pdf/ I went to proj.org and found "Documentation in PDF and zipped HTML can be downloaded using the flyout menu on the left side of the browser window." but couldn't find anything on the left. On the bottom right there is a funky floating menu, and could switch to 9.8 and then PDF and that led to https://proj.org/_/downloads/en/9.8/pdf/ which is not the 9.8 manual; it's the 9.8.1 manual. The file I downloaded earlier was also the 9.8.1 manual, but it's different. The URL https://proj.org/en/stable/_/downloads/en/9.8.1/pdf/ is not found. The files I downloaded earlier and just now: $ ls -l total 98886 -rw-r--r-- 1 gdt users 48630680 Apr 28 18:29 proj-doc-9.8-20260428.pdf -rw-r--r-- 1 gdt users 48630679 Jul 3 03:04 proj-doc-9.8-20260703.pdf (pdftotext) $ diff -u proj-doc-9.8-20260428.txt proj-doc-9.8-20260703.txt --- proj-doc-9.8-20260428.txt 2026-07-06 08:18:19.822051535 -0400 +++ proj-doc-9.8-20260703.txt 2026-07-06 08:18:37.116398639 -0400 @@ -7726,7 +7726,7 @@ 7.1. Projections -Polyhedral, equal area +Polyhedral Forward and inverse, spherical and ellipsoidal Global airocean I'm not sure how this is generated, and what's to be done. I see two problems for packagers: - Docs for 9.8.1 are at a URL that says 9.8 + Probably The pdf was replaced from the 9.8 pdf at some point. + A pdf for 9.8 is no longer available to download. - The pdf for 9.8.1 has changed. Ideally, the pdf would be generated at release time by CI, named with the release version numbers, placed in the same download area as the sources, and then treated as immutable just like releases. I've got a workaround, to name the pdfs back to what they should be at download time, and add a nano if they are changed after posting. How are other packagers dealing with this (other than "don't package proj docs")? From strk at kbt.io Mon Jul 6 07:54:54 2026 From: strk at kbt.io (Sandro Santilli) Date: Mon, 6 Jul 2026 16:54:54 +0200 Subject: [PROJ] false positive of cppcheck? In-Reply-To: <8d3954dc-2a33-4a90-ad5c-6ee1ab3c3ae1@betaapp.fastmail.com> References: <8d3954dc-2a33-4a90-ad5c-6ee1ab3c3ae1@betaapp.fastmail.com> Message-ID: On Mon, Jul 06, 2026 at 12:54:03PM +0300, Lauren?iu Nicola wrote: > Hi Javier, > > It looks like a regression in cppcheck 2.22-dev (2.21 works). I minimized it to: > > extern bool f(); > int main() { > bool datumAdded = false; > if (f()) { > if (f()) return 1; > if (f()) datumAdded = true; > } > if (datumAdded); // style: Condition 'datumAdded' is always false > } > > I wanted to report it, but I honestly don't feel like dealing with their registration process (see what I mean about the OSGeo mantra, strk?). I know the mantra is an obstacle, but it was intentional :) Out of curiosity, where is "their registration process" ? I don't find it in this email. > Daniel, please take a look at the snippet above or, if not, create an account for me: > > lnicola:$2y$10$K2I2FWFyLHMGZh/CYsMaTO4g3N1PzeN37JAo85616xmwMCnb7HiyW This is a great way to request an account. See how easy it would be for us to reply with a mantra, rather than having to figure out how to use your hashed password with LDAP ? ;) --strk; -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: From even.rouault at spatialys.com Mon Jul 6 08:50:39 2026 From: even.rouault at spatialys.com (Even Rouault) Date: Mon, 6 Jul 2026 17:50:39 +0200 Subject: [PROJ] false positive of cppcheck? In-Reply-To: <8d3954dc-2a33-4a90-ad5c-6ee1ab3c3ae1@betaapp.fastmail.com> References: <8d3954dc-2a33-4a90-ad5c-6ee1ab3c3ae1@betaapp.fastmail.com> Message-ID: <53c5b361-6415-4004-a8d8-b01e9bbcbd7b@spatialys.com> Hi?Lauren?iu thanks for the reproducer. Posted at https://trac.cppcheck.net/ticket/14895 with a bisection to the commit that introduced the regression I've tried to rework slightly the case to avoid the false positive, but didn't manage Even Le 06/07/2026 ? 11:54, Lauren?iu Nicola via PROJ a ?crit?: > Hi Javier, > > It looks like a regression in cppcheck 2.22-dev (2.21 works). I > minimized it to: > > extern bool f(); > int main() { > ??? bool datumAdded = false; > ??? if (f()) { > ??????? if (f()) return 1; > ??????? if (f()) datumAdded = true; > ??? } > ??? if (datumAdded); //?style: Condition 'datumAdded' is always false > } > > I wanted to report it, but I honestly don't feel like dealing with > their registration process (see what I mean about the OSGeo mantra, > strk?). > > Daniel, please take a look at the snippet above or, if not, create an > account for me: > > lnicola:$2y$10$K2I2FWFyLHMGZh/CYsMaTO4g3N1PzeN37JAo85616xmwMCnb7HiyW > > Laurentiu > > On Mon, Jul 6, 2026, at 10:26, Javier Jimenez Shaw via PROJ wrote: >> After updating my repo to upstream, I get this error >> >> https://github.com/jjimenezshaw/PROJ/actions/runs/28773629301/job/85312573467 >> >> Cppcheck 2.22 dev >> Running cppcheck on /home/runner/work/PROJ/PROJ/./scripts/../src... >> (can be long) >> /home/runner/work/PROJ/PROJ/src/iso19111/io.cpp:7259,style,knownConditionTrueFalse,Condition >> '!datumAdded' is always true >> knownConditionTrueFalse check failed >> >> Is it a false positive? >> >> In >> https://github.com/OSGeo/PROJ/actions/runs/28773631888/job/85312581973 >> the failure is there, but the test is green. >> >> Am I missing anything? >> >> Thank you >> Javier >> _______________________________________________ >> PROJ mailing list >> PROJ at lists.osgeo.org >> https://lists.osgeo.org/mailman/listinfo/proj >> > > > _______________________________________________ > PROJ mailing list > PROJ at lists.osgeo.org > https://lists.osgeo.org/mailman/listinfo/proj -- http://www.spatialys.com My software is free, but my time generally not. LLMs contribute to global warming and brain rot -------------- next part -------------- An HTML attachment was scrubbed... URL: