[QGIS Commit] [qgis/Quantum-GIS] f01c6a: Simple fix for #5754 (Mac OS-specific). Better fix...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qgis/Quantum-GIS
  Commit: f01c6ad8c820a68e3d3050921b22781e100209d2
      https://github.com/qgis/Quantum-GIS/commit/f01c6ad8c820a68e3d3050921b22781e100209d2
  Author: Larry Shaffer <larrys at dakotacarto.com>
  Date:   2012-06-10 (Sun, 10 Jun 2012)

  Changed paths:
    M src/app/qgisapp.cpp
    M src/app/qgisapp.h
    M src/ui/qgisapp.ui

  Log Message:
  -----------
  Simple fix for #5754 (Mac OS-specific). Better fix would be to make a method that set all QAction additions to base menus (submenus ok) to QAction::NoRole. This would keep any new action from hijacking the Mac app's About or Preferences… menus.

See: http://doc.qt.nokia.com/4.7.1/qmenubar.html#qmenubar-on-mac-os-x


  Commit: 7f1a4e28d12e3fc2bd40d596a4f09138ed368f79
      https://github.com/qgis/Quantum-GIS/commit/7f1a4e28d12e3fc2bd40d596a4f09138ed368f79
  Author: Larry Shaffer <larrys at dakotacarto.com>
  Date:   2012-06-10 (Sun, 10 Jun 2012)

  Changed paths:
    M python/plugins/GdalTools/GdalTools.py
    M src/app/qgisapp.cpp

  Log Message:
  -----------
  Fix for #5753

Does not address third-party plugins that add their own menus. They should use (here for Python):

menu_bar = self.iface.mainWindow().menuBar()
menu_bar.insertMenu( self.iface.firstRightStandardMenu().menuAction(), self.my_plugins_menu )

Ideally, a new QgisInterface public slot pair of addMenuToMenuBar(QMenu)/removeMenuFromMenuBar(QMenu) should be added, to help plugin developers put their menus in the correct place.

Deletion in GdalTools.py is redundant add-to-menu code. It moved the Raster menu to -1 on the menubar (between Window and Help on Mac).


  Commit: d77ce938e4327fdb0f587b0389463538d098d2c2
      https://github.com/qgis/Quantum-GIS/commit/d77ce938e4327fdb0f587b0389463538d098d2c2
  Author: Jürgen Fischer <jef at norbit.de>
  Date:   2012-06-10 (Sun, 10 Jun 2012)

  Changed paths:
    M python/plugins/GdalTools/GdalTools.py
    M src/app/qgisapp.cpp
    M src/app/qgisapp.h
    M src/ui/qgisapp.ui

  Log Message:
  -----------
  Merge pull request #165 from dakcarto/fix-menus-two

Fixes for issues #5753 and #5754


Compare: https://github.com/qgis/Quantum-GIS/compare/769fd5e...d77ce93