[Qgis-developer] Latest features ready to commit - which branch?

[humarco]

Hi Brendan,

Nice to see you are back!
I have some comments about your recent commits:

First of all, thanks for the bugfixes in the snapping code and for making the 
postgresprovider editing code <1.0 compatible.

As far as i see, you changed the snapping code for moveVertex such that it 
uses snap to segment now instead of snap to point? In my opinion, this is a 
new feature and not a bugfix. It is pretty risky to make this in the current 
phase before the release. In this case, this new feature breaks rubber 
banding for moveVertex.
The reason for this is that snap to segment does not set the rubber band 
indexes. This was not necessary up to now, since snap to segment was only 
used for 'addVertex' and for this, the rubber band indexes are just 
vertexNumber-1 and vertexNumber+1. For 'moveVertex', rubber banding is more 
complicated, because the vertex to be moved could be the first vertex of a 
line or the first/last vertex of a polygon ring. Therefore, the indexes of 
the rubber band points are determined in QgsGeometry::closestVertex (but not 
(yet?) in QgsGeometry::closestSegmentWithContext).

> 3. In Vertex editing, add the ability to turn snap-mode (snap the vertex
> being edited to other verticies in the same layer) off.

At the moment, snap-mode can be turned off by setting the tolerance to 0. Ok, 
it may be not so convinient. If you plan to make a checkbox in the gui i 
suggest to do so after 0.8.

Greetings,
Marco



Am Montag, 26. Juni 2006 08:01 schrieb Brendan Morley:
> Hi folks,
>
> I have a few new bits of code lining up to be committed and would like
> to know which branch you think they should be committed to:
>
> 1. In WMS, add the ability to set up a proxy server.
>
> 2. In the vector symbology dialog, add a tooltip to the "no fill" button
> to more clearly indicate what that button does.
>
> 3. In Vertex editing, add the ability to turn snap-mode (snap the vertex
> being edited to other verticies in the same layer) off.
>
> 4. In Vertex editing, when doing a mousedown to choose which geometry to
> edit, the closest geometry will be selected (not just the first within
> snapping range). - bugfix
>
> 5. In Vertex editing, when doing a mousedown to choose which geometry to
> edit, the closest geometry will be selected (not just the first within
> snapping range), then the closest vertex *on that geometry* will be
> selected.  This disambiguates between the same vertex shared amongst
> multiple geometries. - bugfix
>
> 6. In the PostGIS provider, restored the ability to save added and
> changed geometries to pre-1.0 PostGIS servers.  This also now includes
> the ability to sniff the PostGIS version.
>
>
> Thanks,
> Brendan
>
> _______________________________________________
> Qgis-developer mailing list
> Qgis-developer at lists.qgis.org
> http://lists.qgis.org/cgi-bin/mailman/listinfo/qgis-developer