[Qgis-developer] API changes

nhugent at hispeed.ch nhugent at hispeed.ch
Tue Apr 3 15:36:59 EDT 2007

Hi Martin,

>- getNextFeature has parameter featureQueueSize. I think this
>parameter is quite misleading, unused by the code and most providers
>don't use it. I would suggest removing it and let's use some
>predefined value for postgres.

Postgres seems to be the only provider using it. I don't know how important it is for performance there. The strange thing is that it is set from vectorlayer according to the value of mUpdateTreshold, which was originally introduced for screen refresh and not feature queue size. Removing is ok from my side.

>- is it necessary to call reset() everytime after select() ? It would
>be simpler if users could do just select() and then getNextFeature().
>If provider needs to call reset() first, it could be done in select().

That's right, it could be done directly in select().

After these changes, it would be good to have a few days to test before merging.


More information about the Qgis-developer mailing list