[Qgis-developer] vector layer updates heads-up

[Marco Hugentobler]

Hi Jürgen,

The vector layer patch looks very good. I think it is important to incorporate 
the vectorlayer and attribute table changes for 1.0 because of stability of 
1.0 interface.

I could not compile the code with geos2 and had some linker errors with 3.0.0:

/home/marco/src/qgis/build/src/core/libqgis_core.so: undefined reference to 
`GEOSWKTReader_destroy'
/home/marco/src/qgis/build/src/core/libqgis_core.so: undefined reference to 
`GEOSWKTReader_create'
/home/marco/src/qgis/build/src/core/libqgis_core.so: undefined reference to 
`GEOSWKTReader_read'

Also, I saw that you now use featuresInRectangle() for labelling. The drawback 
of featuresInRectangle compared to provider getNextFeature is that it keeps 
all the features in memory (well, in fact that is my fault, because I wrote 
featuresInRectangle() ).
It would be really great to have a method QgsVectorLayer::getNextFeature that 
calls QgsVectorDataProvider::getNextFeature but replaces/adds/deletes the 
changed attributes. Like this, labelling and rendering would always be up to 
date with uncommited changes.

Regards,
Marco 



Am Montag 18 August 2008 01:42:41 schrieb Jürgen E. Fischer:
> Hi Tim,
>
> On Wed, 13. Aug 2008 at 01:00:39 +0200, Tim Sutton wrote:
> > - I have some uncommited stuff to provide table in dock
> >   but ran into issues in this kind of mutimode editing.
>
> I've integrated your work into the patch
>
>
> Jürgen
>
> PS: I'm keeping the uploaded patch on
>     http://buten.norbit.de/~jef/qgis-vlayer.diff
>     uptodate.
> PPS: it's a complete diff of my current working tree and therefore
>      also includes the GEOS C-API changes.
>
> --
> Jürgen E. Fischer         norBIT GmbH               Tel. +49-4931-918175-0
> Dipl.-Inf. (FH)           Rheinstraße 13            Fax. +49-4931-918175-50
> Software Engineer         D-26506 Norden               http://www.norbit.de



-- 
Dr. Marco Hugentobler
Institute of Cartography
ETH Zurich
Technical Advisor QGIS Project Steering Committee