[Qgis-developer] AW: Failing unit tests with recent commits

[Hugentobler Marco]

Hi Tim,

It is still on my todo list. I'm pretty busy and hope to address that next week. Although the changed sizes are in fact a feature, we may declare it as a bug and so I hope it is ok to add the project file transformation after feature freeze ;-)

Regards,
Marco


-----Ursprüngliche Nachricht-----
Von: Tim Sutton [mailto:tim at linfiniti.com]
Gesendet: Mi 11.06.2008 09:54
An: Hugentobler  Marco; qgis-developer at lists.osgeo.org
Betreff: Re: Failing unit tests with recent commits
 
Hi

I just wanted to revisit this before we hit feature freeze. Beyond the
unit tests, I have a number of projects that no longer render
correctly, having outsized symbols and point markers.

Will we be able to resolve this for 0.11.0? Otherwise I suspect we
will get a lot of outcries from folks who have invested a lot of time
constructing qmls and qgses...

Regards

Tim

On 5/17/08, Marco Hugentobler <marco.hugentobler at karto.baug.ethz.ch> wrote:
> Hi Tim,
>
> Yes, good idea to make an automatic project file transformation
>
> The change in the test was still necessary because it is nearly impossible
> to
> find a conversion factor that makes every pixel look the same.
>
> Regards,
> Marco
>
> Am Samstag 17 Mai 2008 16:06:16 schrieb Tim Sutton:
>> Hi Marco
>>
>> I wonder if its not better to make the change in Magnus Homanns rev-up
>> code since this issue is going to affect everyone with old project and
>> QGS files.
>>
>> regards Tim
>>
>> On 5/17/08, Marco Hugentobler <marco.hugentobler at karto.baug.ethz.ch>
>> wrote:
>> > Hi Tim,
>> >
>> > The failing renderer tests are caused by the fact that units are now mm
>> > instead of pixel.
>> > I' going to change the width/size values of the test qmls and the test
>> > images
>> > to make it run again.
>> >
>> > Regards,
>> > Marco
>> >
>> > Am Freitag 16 Mai 2008 21:19:56 schrieb Tim Sutton:
>> >> Hi All
>> >>
>> >> Recent commits in the last few days have introduced regressions (as
>> >> can be seen by running the unit tests). Please remember to run the
>> >> unit tests before committing changes to SVN. Currently we only have a
>> >> few tests but they test core stuff like rendering. If you committed
>> >> anything in the last few days please take a look and see if you have
>> >> introduced these issues.
>> >>
>> >> The issues involve mainly symbol sizes for rendering as best I can
>> >> make out. BTW I have not yet tried the test suite under win,but it
>> >> works under mac & lin.
>> >>
>> >> Many thanks
>> >>
>> >> Tim
>> >
>> > --
>> > Dr. Marco Hugentobler
>> > Institute of Cartography
>> > ETH Zurich
>> > Technical Advisor QGIS Project Steering Committee
>> > _______________________________________________
>> > Qgis-developer mailing list
>> > Qgis-developer at lists.osgeo.org
>> > http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>
>
> --
> Dr. Marco Hugentobler
> Institute of Cartography
> ETH Zurich
> Technical Advisor QGIS Project Steering Committee
>

-- 
Sent from my mobile device

Tim Sutton
QGIS Project Steering Committee Member - Release  Manager
Visit http://qgis.org for a great open source GIS
openModeller Desktop Developer
Visit http://openModeller.sf.net for a great open source ecological
niche modelling tool
Home Page: http://tim.linfiniti.com
Skype: timlinux
Irc: timlinux on #qgis at freenode.net