[Qgis-developer] QtWebKit config issue

[a.furieri at lqt.it]

Hi,

I've just discovered a QtWebKit related issue while 
building on Ubuntu 8.04 Hardy Heron [SVN trunk r.12315]
I got the following fatal error:
---------
In file included from /usr/include/qt4/QtWebKit/qwebpage.h:24,
    from /usr/include/qt4/QtWebKit/qwebview.h:25,
    from /usr/include/qt4/QtWebKit/QWebView:1,
    from
/home/sandro/qgis_1.4/build-sandro/src/helpviewer/ui_qgshelpviewerbase.h:20,
    from /home/sandro/qgis_1.4/src/helpviewer/qgshelpviewer.h:22,
    from /home/sandro/qgis_1.4/src/helpviewer/main.cpp:22:
/usr/include/qt4/QtWebKit/qwebsettings.h:23:27: error: qwebkitglobal.h: Nessun
file o directory
make[2]: *** [src/helpviewer/CMakeFiles/qgis_help.dir/main.o] Error 1
make[1]: *** [src/helpviewer/CMakeFiles/qgis_help.dir/all] Error 2
make: *** [all] Error 2
---------

this one seems to be a well-known issue; please see:
http://lists.trolltech.com/qt-interest/2008-05/thread00222-0.html

Accordingly to this, I've then modified -/src/helpviewer/CMakeLists.txt
-------
SET (QT_USE_QTWEBKIT TRUE)
IF (WIN32) 
  SET (QT_USE_QTMAIN TRUE)
ENDIF (WIN32)
FIND_PACKAGE( Qt4 REQUIRED )
INCLUDE( ${QT_USE_FILE} )
-------

after I've applied the above changes I'll finally be able 
to get a clean build on Ubuntu 8.04
I suppose this CMakeLists.txt patch is required anyway,
but I'm not too confident on this ...

Please, can any cmake/Qt 'guru' check and confirm this
before I commit the above change to SVN ?

best regards,
Sandro Furieri