[Qgis-developer] [Plugin] Added, deleted or changed features in a layer

[Tim Sutton]

Hi
8<-------snip--------------

> 
> OK, I will attach the patch to ticket #1482 in a few days.
> Does my proposition in the ticket respect the coding standards ?

We dont use 'get' get prefix for accessors, so they should be called:

const QgsFeatureIds?& deletedFeaturesIds() const
const QgsFeatureList?& addedFeatures() const 
const QgsGeometryMap?& changedGeometries() const

Also dont forget the new methods should be added to the corresponding
sip file so that they appear in python bindings!

Finally, when you add methods, you should include a doxygen note to
indicate the method is new to QGIS 1.1 e.g.

/* Accessor for the list of features pending deletion when the layer is
next saved.
* @note this method was added in QGIS 1.1
* @return const QgsFeatureIds containing the features to be deleted.
*/


Best regards

Tim

> 
> Regards,
> 
> Olivier
>  

8<-------snip--------------





-- 
Tim Sutton - QGIS Project Steering Committee Member (Release  Manager)
==============================================
Visit http://linfiniti.com to find out about:
 * QGIS programming services
 * Mapserver and PostGIS based hosting plans
 * FOSS Consulting & Support Services
Skype: timlinux Irc: timlinux on #qgis at freenode.net
==============================================
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.osgeo.org/pipermail/qgis-developer/attachments/20090110/d5842f91/attachment.bin