[Qgis-developer] Re: [QGIS Commit] r13578 - trunk/qgis/src/app

[Marco Hugentobler]

Am Mittwoch, 26. Mai 2010, um 20.52:50 schrieb William Kyngesburye:
> It's there - src/app/qgisapp.cpp:2793

But on l. 2793, there is addSpatiaLiteLayer(), not newSpatialiteLayer()


> maybe there's a problem in the moc processing?
> 
> -----
> William Kyngesburye
> <kyngchaos at kyngchaos.com>
> <http://www.kyngchaos.com>
> 
> Don't Panic
> 
> On May 26, 2010, at 1:30 PM, Marco Hugentobler
> <marco.hugentobler at sourcepole.ch
> 
>  > wrote:
> > Hi William
> > 
> > In case of newSpatialiteLayer(), there seems to be no (conditional)
> > empty
> > function in qgisapp.cpp. Therefore, if HAVE_SPATIALITE is not
> > defined, there
> > would be a linker error (see e.g. http://lists.osgeo.org/pipermail/qgis-
> > developer/2010-May/010019.html)
> > 
> > Regards,
> > Marco
> > 
> > Am Mittwoch, 26. Mai 2010, um 16.22:49 schrieb William Kyngesburye:
> >> Marco, I wonder what the compile problem is? I changed this recently
> >> because HAVE_SPATIALITE wasn't registering at this point in the OSX
> >> Xcode project (I need to look into it closer to see why).
> >> 
> >> As I saw it it's just like PostGIS - the function is always defined
> >> in
> >> qgisapp.h, then conditionally is an empty funtion in qgisapp.cpp
> >> depending on  HAVE_SPATIALITE.
> >> 
> >> -----
> >> William Kyngesburye
> >> <kyngchaos at kyngchaos.com>
> >> <http://www.kyngchaos.com>
> >> 
> >> Don't Panic
> >> 
> >> On May 26, 2010, at 7:13 AM, svn_qgis at osgeo.org wrote:
> >>> Author: mhugent
> >>> Date: 2010-05-26 08:13:21 -0400 (Wed, 26 May 2010)
> >>> New Revision: 13578
> >>> 
> >>> Modified:
> >>> trunk/qgis/src/app/qgisapp.h
> >>> 
> >>> Log:
> >>> fix for compile problem
> >>> 
> >>> Modified: trunk/qgis/src/app/qgisapp.h
> >>> ===================================================================
> >>> --- trunk/qgis/src/app/qgisapp.h    2010-05-26 12:08:35 UTC (rev
> >>> 13577)
> >>> +++ trunk/qgis/src/app/qgisapp.h    2010-05-26 12:13:21 UTC (rev
> >>> 13578)
> >>> @@ -500,10 +500,10 @@
> >>> 
> >>>   void fileNew( bool thePromptToSaveFlag );
> >>>   //! Create a new empty vector layer
> >>>   void newVectorLayer();
> >>> 
> >>> -    //#ifdef HAVE_SPATIALITE
> >>> +    #ifdef HAVE_SPATIALITE
> >>> 
> >>>   //! Create a new empty spatialite layer
> >>>   void newSpatialiteLayer();
> >>> 
> >>> -    //#endif
> >>> +    #endif
> >>> 
> >>>   //! Print the current map view frame
> >>>   void newPrintComposer();
> >>>   void showComposerManager();
> >>> 
> >>> _______________________________________________
> >>> QGIS-commit mailing list
> >>> QGIS-commit at lists.osgeo.org
> >>> http://lists.osgeo.org/mailman/listinfo/qgis-commit


-- 
Dr. Marco Hugentobler
Sourcepole - Linux & Open Source Solutions
Webereistr. 66, CH-8134 Adliswil, Switzerland
marco.hugentobler at sourcepole.ch http://www.sourcepole.ch
Technical Advisor QGIS Project Steering Committee