[Qgis-developer] Bringing diagrams into labeling-ng

[Marco Hugentobler]

Hi Martin

Great. I'm going to commit probably tomorrow evening.

> - does this imply a complete removal of diagram overlay plugin?

At the moment, the diagram overlay plugin has more options (bar diagrams and 
the proportional svg symbols). Therefore I'm planning to remove overlay code 
and plugin after 1.7 because of backward compatibility.

> - does it make sense to you to remove the "overlays" tab in the
> options dialog? It only allows changing the PAL algorithm, I guess
> barely anyone knows what those options mean (and they don't make any
> difference anyway unless you have a very dense set of label
> candidates)

+1 (going to do this for 1.7)

> - I wonder if it wouldn't better to move QgsDiagramLayerSettings
> instance from QgsVectorLayer to QgsDiagramRendererV2. If I understand
> the code correctly, the diagram layer settings make sense only if
> there exists a diagram renderer, right?

Conceptually, it is the other way round (renderer is a part of the layer 
settings). But agreed, there is no need to keep both variables in the vector 
layer. Keeping only the settings variable should work too.

Regards,
Marco



Am Montag, 14. März 2011, um 10.08:34 schrieb Martin Dobias:
> Hi Marco
> 
> On Wed, Mar 9, 2011 at 3:01 PM, Marco Hugentobler
> 
> <marco.hugentobler at sourcepole.ch> wrote:
> > Hi all
> > 
> > There's a patch now that adds diagram support using QgsPalLabeling
> > (http://trac.osgeo.org/qgis/ticket/3583). It tries to change the labeling
> > classes as little as possible to not introduce additional issues.
> > 
> > Currently available are pie diagrams and text diagrams. My plan is to
> > also support bars (and maybe proportional svg symbols) and to remove the
> > vector overlay classes after 1.7.
> > 
> > What do you think, is it still ok for those changes to go into 1.7?
> > Looking forward to your comments.
> 
> I have looked at the patch and it seems fine to me. Some comments:
> - does this imply a complete removal of diagram overlay plugin?
> - does it make sense to you to remove the "overlays" tab in the
> options dialog? It only allows changing the PAL algorithm, I guess
> barely anyone knows what those options mean (and they don't make any
> difference anyway unless you have a very dense set of label
> candidates)
> - I wonder if it wouldn't better to move QgsDiagramLayerSettings
> instance from QgsVectorLayer to QgsDiagramRendererV2. If I understand
> the code correctly, the diagram layer settings make sense only if
> there exists a diagram renderer, right?
> - please do not forget to add notes to the new classes and new methods
> that they have been added in 1.7, if possible update also the bindings
> (I could help you if necessary)
> 
> Otherwise +1 from me to apply before the feature freeze.
> 
> Regards
> Martin


-- 
Dr. Marco Hugentobler
Sourcepole -  Linux & Open Source Solutions
Churerstrasse 22, CH-8808 Pfäffikon SZ, Switzerland
marco.hugentobler at sourcepole.ch http://www.sourcepole.ch
Technical Advisor QGIS Project Steering Committee