[Qgis-developer] QgisApp::getThemePixmap() should be in QgsApplication instead?

[Etienne Tourigny]

Committed - there were quite a few changes, and I checked a few
dialogs to make sure it it ok. If anything is funky in icons, the
cause might be here.

On Mon, Jul 16, 2012 at 2:41 PM, Martin Dobias <wonder.sk at gmail.com> wrote:
> On Mon, Jul 16, 2012 at 7:24 PM, Etienne Tourigny
> <etourigny.dev at gmail.com> wrote:
>>> Do you want to keep QgisApp::getThemePixmap in 2.0 as deprecated or do
>>> you want to deprecate it for a while and remove before 2.0 release?
>>
>> I would mark it as deprecated it for a time, but remove it entirely
>> from qgisapp before 2.0 is released.
>
> Given that QgisApp methods can be used only within QGIS application
> sources (src/app folder), it is really sufficient to change all
> occurrences of getThemePixmap() to use QgsApplication, no need to keep
> it as deprecated.
>
> In any case, we should not release 2.0 with deprecated methods / classes.
>
> Regards
> Martin