[Qgis-developer] Unit tests failing - a heartfelt plea

[Radim Blazek]

On Fri, Jun 15, 2012 at 10:53 PM, Tim Sutton <lists at linfiniti.com> wrote:
> Hi
>
> On Fri, Jun 15, 2012 at 5:44 PM, Radim Blazek <radim.blazek at gmail.com> wrote:
>> I wanted to bisect the first wrong commit after 1.8 but I found that
>> final-1_8_0 also fails in qgis_rasterlayertest and qgis_rendererstest.
>> Is it possible? Release was made with broken tests? Is it my local
>> problem? Are the tests independent of user settings?
>>
>> OTOH, the results for final-1_8_0 of qgis_rasterlayertest are much
>> better than latest master.
>>
>
> Can you run make Experimental and then share the link to your uploaded
> test for 1.8.0? Probably you have small rendering anomalies which
> cause the tests to fail - we can add the test results to the anomalies
> list if this is the case.

Here it is http://dash.orfeo-toolbox.org/viewTest.php?buildid=87438
it looks interesting. In the first raster test called 'raster', some
columns are wider, some others are narrower. In following raster
tests, the problem may be the same (columns and rows somehow shifted).

There is a lot of other fails but those seems to be false alarms,
tests pass ok, but then it crashes, probably.

Radim

> Regards
>
> Tim
>
>> Radim
>>
>>
>> On Fri, Jun 15, 2012 at 11:41 AM, Tim Sutton <lists at linfiniti.com> wrote:
>>> Hi All
>>>
>>> I just want to make a heartfelt plea that any new code pushed to Git
>>> master should not break tests (at minimum on the platform on which you
>>> are working). If you do radical changes, the test suite should be
>>> updated to accommodate them so that the tests still pass for your
>>> platform when you commit. I would like to see the test suite grow to
>>> encompass  as much functionality of QGIS as possible, but it will be
>>> very difficult to maintain them if we commit code that breaks them.
>>> You can always view the state of the last nightly builds here:
>>>
>>> http://dash.orfeo-toolbox.org/index.php?project=QGIS
>>>
>>> You can test your work before pusing it to master by doing:
>>>
>>> make test
>>> make check
>>>
>>> or (to share your test results)
>>>
>>> make Experimental
>>>
>>> Thanks!
>>>
>>> Regards
>>>
>>>
>>>
>>> --
>>> Tim Sutton - QGIS Project Steering Committee Member (Release  Manager)
>>> ==============================================
>>> Please do not email me off-list with technical
>>> support questions. Using the lists will gain
>>> more exposure for your issues and the knowledge
>>> surrounding your issue will be shared with all.
>>>
>>> Visit http://linfiniti.com to find out about:
>>>  * QGIS programming and support services
>>>  * Mapserver and PostGIS based hosting plans
>>>  * FOSS Consulting Services
>>> Skype: timlinux
>>> Irc: timlinux on #qgis at freenode.net
>>> ==============================================
>>> _______________________________________________
>>> Qgis-developer mailing list
>>> Qgis-developer at lists.osgeo.org
>>> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>
>
> --
> Tim Sutton - QGIS Project Steering Committee Member (Release  Manager)
> ==============================================
> Please do not email me off-list with technical
> support questions. Using the lists will gain
> more exposure for your issues and the knowledge
> surrounding your issue will be shared with all.
>
> Visit http://linfiniti.com to find out about:
>  * QGIS programming and support services
>  * Mapserver and PostGIS based hosting plans
>  * FOSS Consulting Services
> Skype: timlinux
> Irc: timlinux on #qgis at freenode.net
> ==============================================