[Qgis-developer] Deprecated labels tab 'removal' pull request

[Larry Shaffer]

Hi,

I have a pull request to remove deprecated labels properties tab from
vector layer properties, if not used by an older project [0]. I've tested
it, but did not commit it because it included a public function for QgisApp
(though no Python binding). If anyone who can pass judgement upon it thinks
it is OK, please merge it, or let me know if I can.

This is the handling of the deprecated labels tab I figured was best:

* Deprecated labels tab remains active for all layers in an older project,
if any layer uses them, for the duration of project's open session
(including when saving project instance with no layers that use deprecated
labels).

* Caveat (feature?):  If all layers no longer use deprecated labels on
project close, when project is reopened, deprecated labels tab will no
longer be available. Some users may not like this, but they are being
warned about opening an older project version.

* New projects, or opened older projects that do not use deprecated labels,
will never show the deprecated labels tab. With those projects, there is no
way to enable the deprecated labeling tab.

Please let me know if I am off-the-mark with this workflow.

My logic is that if someone is still using deprecated labels in a project,
that type of labeling should remain available to all layers in the project.
I created an earlier branch where the deprecated labels tab was only turned
on for the layers that use deprecated labels [1]. However, this was fairly
limiting (see commit message) and would probably annoy users.


[0] https://github.com/qgis/Quantum-GIS/pull/851
[1] https://github.com/dakcarto/Quantum-GIS/commit/7eb4866f

Regards,

Larry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20130831/8a0feea7/attachment-0001.html>