[Qgis-developer] QgsColorButton

[Matthias Kuhn]

On 01/07/2013 05:29 PM, Martin Dobias wrote:
> On Mon, Jan 7, 2013 at 5:15 PM, Werner Macho <werner.macho at gmail.com> wrote:
>> OK - Then I was wrong with my guess .. :)
>> @Martin .. is V2 a better implementation or is it ok to stick with the
>> original code? Just because most people prefer to use the original code does
>> not mean that they should not use V2 if it is better ..
>>   But I see you already voted for removing V2
> No, in this case V2 is not better, it's just different :-)
V2 is used in symbology, while the old one is used in diagrams.

I don't care too much, which one should be removed. I just prefer to 
keep it consistent.

>
>
>> anyway - what about implementation into the Widget?
> Automatic handling of the button click (+signal for color change) may
> be useful. But prior to changing that I would suggest looking at the
> code to see if we need to handle some special cases. For example, I
> think for some color dialogs we use ShowAlphaChannel option for
> QColorDialog.
>
> Martin
Passing optional ColorDialogOptionsto the QgsColorButton should help in 
this case.
I'll see if I stumble across any other special needs.