[Qgis-developer] Virtual Fields - Allow adding fields out of edit mode

[Bernhard Ströbl]

Hi Matthias,

there seems to be a small bug in the add field stuff: scenario
1) add a virtual field
2) add a permanent field => field is added but marked as virtual 
(symbol) and name is that of the virtual field added in step 1) BUG!
3) close and reopen layer properties => field from step 2) is displayed 
as it should, so the bug is on the display side only

tested with e5850f3

to your question: I think the current editing-mode behavior is 
intuitive. What is not intuitive is that the expression editor can only 
be launched when adding a virtual field. I am aware that I can add a 
(permanent) field with the field calculator but this whole business is 
IMHO not consistent.
This would be consistent:
1) in field calculator if choosing to add a new field offer to make it 
virtual or permanent (permanent being default)
2) make add-field dialog be the same no matter if adding a permanent or 
virtual field.

regards

Bernhard

Am 06.10.2014 21:12, schrieb Matthias Kuhn:
> Hi,
>
> I merged a commit today that fixes some problems with virtual fields, in
> particular a crash when removing a virtual field.
> As the virtual fields do not work on the data provider, they are not
> directly linked to edit mode being turned on. This also allows to add
> virtual fields on data providers that do not allow to add additional
> fields. This led to a change in the GUI, that you are also allowed to
> add fields when edit mode is turned off. I added an info, that editing
> mode will be turned on, when adding real (provider) fields on the add
> field dialog.
> However, I am not sure how intuitive the current behavior is. As we are
> approaching the final release date, I thought I'd explicitly point out
> this change and ask for feedback so we can take measures if there is
> hesitation to this approach.
>
> Please share your impression and if you disagree with the current
> approach it would be highly welcome if you could outline an improved way
> of tackling this.
>
> Matthias


__________ Information from ESET Mail Security, version of virus signature database 10522 (20141007) __________

The message was checked by ESET Mail Security.
http://www.eset.com