[Qgis-developer] Night Mapping theme, changeset da3f7be

[S Mizuno]

Hi Nathan, I just noticed the recent addition of UI themes / Night Mapping and how Qt stylesheets are used to implement it. This is a great idea, but there are a few things to be careful of. In particular, changing the theme to Night Mapping is OK, but changing back to 'default' causes QGis to crash, due to the stylesheet file referenced not existing. And the Style setting in options shows blank on first use of the new theme. Clicking OK on the Options (and possibly other actions) causes the WindowsVista (on my computer) style to be use on subsequent QGIS start. I had recently begun to try using stylesheets to set things, such as icon size, and have found some issues: + setting an invalid stylesheet may cause QGIS crash (when setting style after the stylesheet -- not a common practice, or even setting a defective stylesheet), so don't set something like 'file:///style.qss' if the file doesn't exist. + setting a stylesheet on application object hinders recovery of the style name as used in the Options dialog; probably should track the style as a text value and not recover from the style object. + using a stylesheet on the application object to set icon size, for example, seems a better idea to me than to program a specific set of controls to get the size as is done now. + in spite of Qt docs noting that setting style after QApplication object creation isn't recommended, I have done so successfully, except when there is a defective stylesheet present. + presently, the font and certain other settings applied by stylesheet are on the main window so only child windows get the styling. The stylesheet really should be set on the application so all windows of the app get the styling. + any stylesheet settings applied directly need to be integrated with any additional settings from a file. I not sure how to do both direct settings and include a file, too, at the present time. I am not well Internet connected right now, so it may be a while before I respond to any replies. Steven Mizuno
____________________________________________________________
Buffett’s New Enemy
Buffett just confirmed his worst fear. Click here for his warning.
http://thirdpartyoffers.netzero.net/TGL3231/55e31dcc446321dcc1ee4st01vuc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20150830/bd77d835/attachment.html>