[Qgis-developer] Failing tests

Nyall Dawson nyall.dawson at gmail.com
Mon Jun 1 20:34:56 PDT 2015


On 2 June 2015 at 05:24, Matthias Kuhn <matthias at opengis.ch> wrote:


>
> I am a hippy. I don't like rules and policies. I am not in favor of a
> very strong policy concerning the tests. Common sense should be valued
> more than rules. Policies like "every new feature has to come with a
> test" are no good solution as they encourage people to write silly
> tests. And I am much too lazy to write a QEP for a policy to revert
> commits which break the tests.
>
> So... How do we fix it?
> If tomorrow everybody on this list writes some API documentation we
> should have fixed that test by noon.

Doc tests pass now... just the startup one left to repair.

I'd be in favour of a hardline "no breaks allowed" approached. You
break travis, your commit gets reverted. We shouldn't be allowing
intentional regressions, and if the test itself is broken then this
should be fixed before the failing commit is pushed to master.

Nyall


More information about the Qgis-developer mailing list