[Qgis-developer] PR review about DB Manager

[Giuseppe Sucameli]

Merged and closed both PR.
Best regards.
Giuseppe

On Tue, May 26, 2015 at 1:25 PM, Etienne Trimaille <
etienne.trimaille at gmail.com> wrote:

> Sorry for the double merge. It comes after the work from Hugo.
>
> This feature was on the changelog for 2.8, but the selected query couldn't
> be loaded on the map canvas. We could only execute the selected part to see
> the table in the sql window. That's why there is a backport.
>
>
>
> 2015-05-26 10:54 GMT+02:00 Giuseppe Sucameli <brush.tyler at gmail.com>:
>
>> Hi,
>> I agree the changes are good,
>>
>> I don't know if the double merge on PR 1999 could break something, but we
>> can just pick the right commit.
>>
>>
>>
>> On Tue, May 26, 2015 at 9:46 AM, René-Luc Dhont <rldhont at gmail.com>
>> wrote:
>>
>>> I looked at the code and it's pretty simple. If some code are selected,
>>> the selection has run otherwise all the code has run.
>>>
>>> Some one to agree this PR ?
>>>
>>> Le 25/05/2015 19:08, Paolo Cavallini a écrit :
>>>
>>>> Am 25.05.2015 um 18:40 schrieb Etienne Trimaille:
>>>>>
>>>>>> I opened two PR one month ago about to run only a selected query in
>>>>>> the db manager.
>>>>>>
>>>>>> https://github.com/qgis/QGIS/pull/1999
>>>>>> https://github.com/qgis/QGIS/pull/2000
>>>>>>
>>>>>> Could you please review them and merge ?
>>>>>>
>>>>> Agreed, it would be good to have them.
>>>> Anyone can review them?
>>>> Thanks.
>>>>
>>>
>>> _______________________________________________
>>> Qgis-developer mailing list
>>> Qgis-developer at lists.osgeo.org
>>> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>>>
>>
>>
>>
>> --
>> Giuseppe Sucameli
>>
>> _______________________________________________
>> Qgis-developer mailing list
>> Qgis-developer at lists.osgeo.org
>> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>>
>
>


-- 
Giuseppe Sucameli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20150527/474cc2ee/attachment.html>