[Qgis-developer] Fwd: Re: [QGIS] Processing algorithm test framework (#2648)

Matthias Kuhn matthias at opengis.ch
Tue Feb 16 03:09:13 PST 2016


Hi Paolo

I will be glad to receive more tests! I would appreciate if you could
make aware of this in you classes.

On 02/16/2016 10:13 AM, Paolo Cavallini wrote:
> Hi all,
> why not make it easier for people to contribute tests, by removing
> unnecessary steps (git may be a blocker for many).
> Maybe we can:
> * point the user to sample data with a simple zipfile
> * ask the user to send the file from Create test and the result to an
> email address
> * integrate them ourselves into git.
> I'm sure this will increase the number of testers, with a reasonable
> effort from our side. I'm available to do it if no one else is available.


We can give the "send tests as zip" way a try, if this is really a
blocker for people.

Creating tests is not always as trivial, sometimes it may be required to
fine tune some parameters for fuzzy comparison (e.g. precision of
coordinates) or disable that certain fields are compared (e.g.
additional duplicate id's depending on ogr version). These steps can
only be done after having the result of travis tests, so somebody may
still need to take care of that.

>
> BTW, Create test throws an error here:
>
> An error has occurred while executing Python code:
>
> AttributeError: 'NoneType' object has no attribute 'ReadAsArray'
> Traceback (most recent call last):
>   File "/usr/share/qgis/python/plugins/processing/gui/HistoryDialog.py",
> line 128, in createTest
>     TestTools.createTest(item.entry.text)
>   File "/usr/share/qgis/python/plugins/processing/gui/TestTools.py",
> line 167, in createTest
>     strhash = hashlib.sha224(dataset.ReadAsArray(0).data).hexdigest()
> AttributeError: 'NoneType' object has no attribute 'ReadAsArray'

That's interesting. I tried to integrate a gdal raster test on travis
(see here https://github.com/qgis/QGIS/pull/2761) it passes on my system
and on travis/osx but not on travis/linux. It seems that the output
raster cannot be opened by gdal (we do this to calculate a checksum).
Can you give me some information about your system, gdal version and
output raster format?

Bests
>
> All the best.
>
> -------- Messaggio Inoltrato --------
>
> And for those who wonder:
>
> http://www.opengis.ch/2016/02/04/increasing-the-stability-of-processing-algorithms/
>
>> Reply to this email directly or view it on GitHub
> <https://github.com/qgis/QGIS/pull/2648#issuecomment-179997935>.
>
>
>
> _______________________________________________
> Qgis-developer mailing list
> Qgis-developer at lists.osgeo.org
> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer

-- 
Matthias Kuhn
OPENGIS.ch - https://www.opengis.ch
Spatial • (Q)GIS • PostGIS • Open Source


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20160216/9e589105/attachment.sig>


More information about the Qgis-developer mailing list