[Qgis-developer] Possible code duplication: QgsOWSSourceSelect vs. specific widgets

Alexander Bruy alexander.bruy at gmail.com
Tue Jan 5 22:55:59 PST 2016


HI all,

when looking at the code of the OWS providers I noticed possible
code duplication. There is a QgsOWSSourceSelect class [0, 1]
which is used only by WCS provider and OWS metaprovider. Other
providers, namely WMS and WFS use their own implementations
and have separate *.ui files.

Should we drop QgsOWSSourceSelect in favor of the specific
implementations or move all providers to use this class?

[0] https://github.com/qgis/QGIS/blob/master/src/gui/qgsowssourceselect.h
[1] https://github.com/qgis/QGIS/blob/master/src/gui/qgsowssourceselect.cpp

-- 
Alexander Bruy


More information about the Qgis-developer mailing list