[Qgis-developer] Can I change QgsAbstractGeometryV2::fromWkb signature ?

Matthias Kuhn matthias at opengis.ch
Tue Jan 26 07:53:20 PST 2016

On 01/26/2016 04:45 PM, Sandro Santilli wrote:
> On Tue, Jan 26, 2016 at 01:52:41PM +0100, Matthias Kuhn wrote:
>> I would add a second method with size param and deprecate the current one.
>> This way we can prepare our own code and remove the dangerous method in 3.0
> Consider that QgsGeometry::fromWkb() already takes a size parameter:
> https://github.com/qgis/QGIS/blob/master/src/core/geometry/qgsgeometry.h#L141-L145
> It's just not passed over to the QgsAbstractGeometryV2::fromWkb.
> Is the "internal" call still to be considered part of the API ?

Why not?
Is there a problem with the proposed approach? I would say it is quite
safe and future proof.


> --strk;

Matthias Kuhn
OPENGIS.ch - https://www.opengis.ch
Spatial • (Q)GIS • PostGIS • Open Source

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20160126/f0485585/attachment.sig>

More information about the Qgis-developer mailing list