[Qgis-developer] [processing] OGR imports full of "None" strings, lately

Sandro Santilli strk at kbt.io
Tue Oct 18 06:42:33 PDT 2016


On Tue, Oct 18, 2016 at 03:38:27PM +0200, Sandro Santilli wrote:
> On Tue, Oct 18, 2016 at 12:48:18PM +0200, Victor Olaya wrote:
> > >
> > > It sounds like having getParamaterValue() always return a string
> > > (possibly empty) would reduce regression probabilities.
> > >
> > > Or do you think it's important to distinguish between empty string
> > > and None ?
> > 
> > sounds safe to me. And it would be nicer to make that distinction, but
> > i think it is not so important. I cannot think of any major issue with
> > that
> 
> Well, I tried and SURPRISE ! The parameter is actually *set*
> to the "None" string. So I guess the bug is also on the *set* side,
> not (just) *get* one.
> 
> Also, a quick review of the set side (setValue functions) reveal that
> the value of parameters don't necessarely need to be strings ?

It looks like reverting 61a10df45283a47782bf49ac62f9c5e5f9b27b21
removes all those "None" literals.

See
https://github.com/qgis/qgis/commit/61a10df45283a47782bf49ac62f9c5e5f9b27b21


--strk;


More information about the Qgis-developer mailing list