[Qgis-developer] [processing] OGR imports full of "None" strings, lately

[Germán Carrillo]

My bad, Victor. I was testing against an old build. Just re-built QGIS and
the None is gone.
Thanks for the fix.

Regards,

Germán

2016-10-19 16:05 GMT-05:00 Victor Olaya <volayaf at gmail.com>:

> hmm, it's strange that you get None...If the value pased is empty or None,
> it should set an empty string as value
>
> see: https://github.com/qgis/QGIS/commit/d911671b0669d3654d85954b52e38a
> 9f5e952d4a
>
> I adapted the test to check that, and it is passing
>
> see: https://github.com/qgis/QGIS/commit/0d09ad1ecd4a850c421bb1820e3d58
> 23dde5d33f
>
> 2016-10-19 22:55 GMT+02:00 Germán Carrillo <carrillo.german at gmail.com>:
>
>> After rebasing a few hours ago, I'm still having issues (None appearing
>> in ogr2ogr commands) with the same example described in this comment [1]
>> (OGR "Convert format" algorithm).
>>
>> Am I doing something wrong? Should I fix/adjust/add something to OGR
>> algorithms?
>>
>> Regards,
>>
>> Germán
>>
>> --
>> [1] https://github.com/qgis/QGIS/commit/61a10df45283a47782bf
>> 49ac62f9c5e5f9b27b21#commitcomment-19464285
>>
>>
>> 2016-10-18 11:19 GMT-05:00 Victor Olaya <volayaf at gmail.com>:
>>
>>> Yes, they should. I will take care of that
>>>
>>> 2016-10-18 17:48 GMT+02:00 Sandro Santilli <strk at kbt.io>:
>>> > On Tue, Oct 18, 2016 at 05:44:43PM +0200, Victor Olaya wrote:
>>> >> I just made this fix, which should solve those issues
>>> >>
>>> >> https://github.com/qgis/QGIS/commit/d7bd5dc50705eec3f37ef82f
>>> c819b5bc47cce0f0
>>> >>
>>> >> Let me know if we need to do something else.
>>> >
>>> > I still think a testcase would be very useful.
>>> > Besides, there seem to be tests checking for "None" (string)
>>> > being returned by setting None (type) in
>>> >
>>> >  python/plugins/processing/tests/ParametersTest.py
>>> >
>>> > Should they be updated ?
>>> >
>>> > --strk;
>>> >
>>>
>>
>>
>>
>> --
>> -----------
>>    |\__
>> (:>__)(
>>    |/
>> Soluciones Geoinformáticas Libres
>> http://geotux.tuxfamily.org/
>> http://twitter.com/GeoTux2
>> http://about.me/germancarrillo
>>
>> <http://gis.stackexchange.com/users/4972/germ%c3%a1n-carrillo>
>>
>
>


-- 
-----------
   |\__
(:>__)(
   |/
Soluciones Geoinformáticas Libres
http://geotux.tuxfamily.org/
http://twitter.com/GeoTux2
http://about.me/germancarrillo

<http://gis.stackexchange.com/users/4972/germ%c3%a1n-carrillo>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20161019/77e2cc25/attachment-0001.html>