<div dir="ltr">Hi!<div><br></div><div style>Well I'd still vote </div><div style>+1</div><div style>for integrating </div><div style><br></div><div style>To me it does make a lot more sense to break the API NOW with 2.0 than introducing some small glitches afterwards again with 2.1 or 2.2</div>
<div style>It's just that the Hackfest starts on Thursday and .. it should be good to have all API changes pulled in by then ..</div><div style><br></div><div style>So if it's possible to just do a small patch for breaking the API and doing the "cleanup" during the bugfix phase I'd still vote for doing it right now!</div>
<div style><br></div><div style>just my 2¢</div><div style><br></div><div style>kind regards</div><div style>Werner</div><div style><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Apr 9, 2013 at 4:52 AM, Larry Shaffer <span dir="ltr"><<a href="mailto:larrys@dakotacarto.com" target="_blank">larrys@dakotacarto.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<br><div><div class="gmail_extra"><br></div><div class="gmail_extra">Here's an update on the labeling work I've been doing for the past week:<br>
<br></div><div class="gmail_extra">* Label backgrounds (geometric shapes and SVG) have been implemented/committed, but currently have a couple of loose ends [0].<br>
<br></div><div class="gmail_extra">* Label drop shadows are essentially functional, and work for label buffers [1]. I need a couple of days to clean up the overly verbose code, simplify the logic and make it work for label text and backgrounds. In the GUI and map canvas screen snaps [2][3] you can see an example of the radius blurring and of the 'global' offset option (there are also debug rectangles shown). When global is checked for shadow offset, rotated label's drop shadows are adjusted to match the global offset for the layer (instead of being relative to the label's rotation). For example, this allows all drop shadows on all labels, or their buffers/backgrounds, to match what a user may have setup in a hill shaded raster, i.e. opposite the angle of a virtual sun. Turning on all these features does slow labeling down, of course. :^)<br>
<br></div><div class="gmail_extra">* Significantly missing functionality currently occurs in the data defined aspect of new labeling features. Many of the new features do not have corresponding data defined options, and the current gui and usage of the data defined values does not mirror that of the new setup by recently committed by Dr. Marco H for symbology. Since labeling does not yet have a rule-based setup, it would be *very good* to have the current data defined setup for labeling switched over to Marco's method. This will allow expressions to be used for all labeling options and give users a solid feature set for labeling to work with until 2.1.<br>
<br></div><div class="gmail_extra">So, I have a couple questions:<br><br></div><div class="gmail_extra">Can I push the cleaned up and functional labeling drop shadows work to master branch in a couple of days, for inclusion in 2.0? It was my understanding this was part of the labeling background work I was temporarily allowed to do, but it has taken a couple of days longer than expected.<br>
<br></div><div class="gmail_extra">Does switching over the data defined backend for labeling constitute a new feature? If not, I'd like to work on it over the next week. <br><br>If switching over the data defined backend is considered a new feature, and not allowed to be committed right now, can I at least work on adding some of the missing data defined options for labeling?<br>
</div><div class="gmail_extra"><br>[0] <a href="https://github.com/qgis/Quantum-GIS/commit/b8097239" target="_blank">https://github.com/qgis/Quantum-GIS/commit/b8097239</a><br>[1] <a href="https://github.com/dakcarto/Quantum-GIS/commits/labeling_dropshadow_4" target="_blank">https://github.com/dakcarto/Quantum-GIS/commits/labeling_dropshadow_4</a><br>
[2] <a href="http://drive.dakotacarto.com/qgis/labeling_drop-shadow-options.png" target="_blank">http://drive.dakotacarto.com/qgis/labeling_drop-shadow-options.png</a><br>[3] <a href="http://drive.dakotacarto.com/qgis/labeling_drop-shadows.png" target="_blank">http://drive.dakotacarto.com/qgis/labeling_drop-shadows.png</a><br>
<br></div><div class="gmail_extra">Regards,<br><br></div><div class="gmail_extra">Larry<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Mar 30, 2013 at 12:18 PM, Andreas Neumann <span dir="ltr"><<a href="mailto:a.neumann@carto.net" target="_blank">a.neumann@carto.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
I'd love to have these label backgrounds and drop shadows in QGIS 2.0.<br>
Makes sense to me to include this work despite feature freeze since a<br>
major effort was made already to improve labeling in QGIS 2.0.<br>
<br>
so +1 from my side.<br>
<br>
Thank you for your work, Larry.<br>
<br>
Andreas<br>
<br>
Am 30.03.2013 12:32, schrieb Larry Shaffer:<br>
> Hi,<br>
><br>
> In an effort to bring a basic label background feature into 2.0 before for<br>
> the freeze, I figured out a good approach that makes adding label<br>
> backgrounds much easier (better late than never, I suppose) [0]. This means<br>
> that adding SVGs and drop shadows for label backgrounds is only an extra<br>
> couple of days of work.<br>
><br>
> Here's a preliminary gui setup [1] (not all may be implemented, but most<br>
> can easily be).<br>
><br>
> An example of generic rounded-corner rectangles (a la web mapping and many<br>
> road shields) with a bit of x/y offset to nicely center the text [2].<br>
><br>
> And, an example of the 'centering' of the background relative to the label<br>
> contents (background rotated 90 deg relative to text) [3], regardless of<br>
> label's offset placement (see pink-text label next to point feature). This<br>
> is a crucial feature for integrating many types of backgrounds.<br>
><br>
> Both examples also show one issue: while labels don't overlap due to<br>
> collision management, their backgrounds might overlap each other or<br>
> previously drawn label text. I believe this is fixable, though I don't know<br>
> how long it will take, off hand.<br>
><br>
> So... basically, I'm asking those who make decisions whether I can work for<br>
> another week on this feature, for inclusion in 2.0.<br>
><br>
> [0] <a href="https://github.com/dakcarto/Quantum-GIS/commits/labeling_bkgrd-symbols_3" target="_blank">https://github.com/dakcarto/Quantum-GIS/commits/labeling_bkgrd-symbols_3</a><br>
> [1] <a href="http://drive.dakotacarto.com/qgis/labeling_background-gui.png" target="_blank">http://drive.dakotacarto.com/qgis/labeling_background-gui.png</a><br>
> [2] <a href="http://drive.dakotacarto.com/qgis/labeling_background-rounded.png" target="_blank">http://drive.dakotacarto.com/qgis/labeling_background-rounded.png</a><br>
> [3] <a href="http://drive.dakotacarto.com/qgis/labeling_background-rotation.png" target="_blank">http://drive.dakotacarto.com/qgis/labeling_background-rotation.png</a><br>
><br>
> Regards,<br>
><br>
> Larry Shaffer<br>
> Dakota Cartography<br>
> Black Hills, South Dakota<br>
><br>
><br>
><br>
> _______________________________________________<br>
> Qgis-developer mailing list<br>
> <a href="mailto:Qgis-developer@lists.osgeo.org" target="_blank">Qgis-developer@lists.osgeo.org</a><br>
> <a href="http://lists.osgeo.org/mailman/listinfo/qgis-developer" target="_blank">http://lists.osgeo.org/mailman/listinfo/qgis-developer</a><br>
><br>
<br>
_______________________________________________<br>
Qgis-developer mailing list<br>
<a href="mailto:Qgis-developer@lists.osgeo.org" target="_blank">Qgis-developer@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/qgis-developer" target="_blank">http://lists.osgeo.org/mailman/listinfo/qgis-developer</a><br>
</blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
Qgis-developer mailing list<br>
<a href="mailto:Qgis-developer@lists.osgeo.org">Qgis-developer@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/qgis-developer" target="_blank">http://lists.osgeo.org/mailman/listinfo/qgis-developer</a><br>
<br></blockquote></div><br></div>