<div dir="ltr">Hey Richard,<div><br></div><div>Leave it with me I will take a look.  I don't mind what we go with but we should have a standard used over the whole app.</div><div><br></div><div>Your PR is fine if <span style="color:rgb(3,47,98);font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;white-space:pre;background-color:rgb(230,255,237)">/</span><span class="gmail-x gmail-x-first gmail-x-last" style="box-sizing:border-box;border-radius:0.2em;color:rgb(36,41,46);background-color:rgb(172,242,189);font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;white-space:pre">qgis</span><span style="color:rgb(3,47,98);font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;white-space:pre;background-color:rgb(230,255,237)">/connections-wms s used in QGIS 3 and </span><span class="gmail-x gmail-x-first gmail-x-last" style="box-sizing:border-box;border-radius:0.2em;color:rgb(36,41,46);background-color:rgb(253,184,192);font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;white-space:pre">Qgis</span><span style="color:rgb(3,47,98);font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;white-space:pre;background-color:rgb(255,238,240)">/connections-wms was in 2.x the translation framework will pick it up ok.</span></div><div><span style="color:rgb(3,47,98);font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;white-space:pre;background-color:rgb(255,238,240)"><br></span></div><div><font color="#032f62" face="SFMono-Regular, Consolas, Liberation Mono, Menlo, Courier, monospace"><span style="font-size:12px;white-space:pre;background-color:rgb(255,238,240)">Regards,</span></font></div><div><font color="#032f62" face="SFMono-Regular, Consolas, Liberation Mono, Menlo, Courier, monospace"><span style="font-size:12px;white-space:pre;background-color:rgb(255,238,240)">Nathan</span></font></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Oct 28, 2017 at 1:13 AM, Richard Duivenvoorde <span dir="ltr"><<a href="mailto:rdmailings@duif.net" target="_blank">rdmailings@duif.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 27-10-17 16:15, Nathan Woodrow wrote:<br>
> Sorry I'm not sure I follow what you mean?<br>
<br>
</span>This pull fixed some WCS related changes, please see comments in the PR:<br>
<br>
<a href="https://github.com/qgis/QGIS/pull/4586" rel="noreferrer" target="_blank">https://github.com/qgis/QGIS/<wbr>pull/4586</a><br>
<br>
I also grepped (at that time) some other key's which contained Qgis with<br>
a capital Q (again see PR):<br>
<br>
python/pyplugin_installer/<wbr>installer_data.py:reposGroup =<br>
"/Qgis/plugin-repos"<br>
python/pyplugin_installer/<wbr>installer_data.py:<wbr>settingsGroup =<br>
"/Qgis/plugin-installer"<br>
python/pyplugin_installer/<wbr>installer_data.py:<wbr>seenPluginGroup =<br>
"/Qgis/plugin-seen"<br>
python/pyplugin_installer/<wbr>installer_data.py:    ("Barry Rowlingson's<br>
Repository",<br>
"<a href="http://www.maths.lancs.ac.uk/~rowlings/Qgis/Plugins/plugins.xml" rel="noreferrer" target="_blank">http://www.maths.lancs.ac.uk/<wbr>~rowlings/Qgis/Plugins/<wbr>plugins.xml</a>"),<br>
python/pyplugin_installer/<wbr>installer.py:        lastDirectory =<br>
settings.value('/Qgis/plugin-<wbr>installer/lastZipDirectory', '.')<br>
python/pyplugin_installer/<wbr>installer.py:<br>
settings.setValue('/Qgis/<wbr>plugin-installer/<wbr>lastZipDirectory',<br>
python/qsci_apis/PyQGIS-2.0.<wbr>api:qgis.gui.<wbr>QgsNewHttpConnection?1(QWidget<br>
parent=None, QString baseKey="/Qgis/connections-<wbr>wms/", QString<br>
connName=QString.null, Qt.WindowFlags fl=QgisGui.ModalDialogFlags)<br>
python/qsci_apis/PyQGIS-2.0.<wbr>api:qgis.gui.<wbr>QgsNewHttpConnection.__init__?<wbr>1(self,<br>
QWidget parent=None, QString baseKey="/Qgis/connections-<wbr>wms/", QString<br>
connName=QString.null, Qt.WindowFlags fl=QgisGui.ModalDialogFlags)<br>
python/qsci_apis/PyQGIS-2.2.<wbr>api:qgis.gui.<wbr>QgsNewHttpConnection?1(QWidget<br>
parent=None, QString baseKey="/Qgis/connections-<wbr>wms/", QString<br>
connName=QString.null, Qt.WindowFlags fl=QgisGui.ModalDialogFlags)<br>
python/qsci_apis/PyQGIS-2.2.<wbr>api:qgis.gui.<wbr>QgsNewHttpConnection.__init__?<wbr>1(self,<br>
QWidget parent=None, QString baseKey="/Qgis/connections-<wbr>wms/", QString<br>
connName=QString.null, Qt.WindowFlags fl=QgisGui.ModalDialogFlags)<br>
python/gui/<wbr>qgsnewhttpconnection.sip:    QgsNewHttpConnection( QWidget<br>
*parent /TransferThis/ = 0, const QString &baseKey =<br>
"/Qgis/connections-wms/", const QString &connName = QString::null, const<br>
Qt::WindowFlags &fl = QgsGuiUtils::ModalDialogFlags );<br>
python/plugins/MetaSearch/<wbr>dialogs/maindialog.py:        # stype = human<br>
name,/Qgis/connections-%s,<wbr>providername<br>
python/plugins/MetaSearch/<wbr>dialogs/maindialog.py:<br>
self.settings.beginGroup('/<wbr>Qgis/connections-%s' % stype[2])<br>
python/plugins/MetaSearch/<wbr>dialogs/maindialog.py:<br>
self.settings.beginGroup('/<wbr>Qgis/connections-%s' % stype[1])<br>
python/plugins/MetaSearch/<wbr>dialogs/maindialog.py:<br>
self.settings.beginGroup('/<wbr>Qgis/connections-%s' % stype[2])<br>
python/plugins/MetaSearch/<wbr>dialogs/maindialog.py:<br>
self.settings.beginGroup('/<wbr>Qgis/connections-%s' % stype[1])<br>
<br>
But I understand now that yours is just about settings object/file, NOT<br>
so much about the code that creates that settings?<br>
<span class="HOEnZb"><font color="#888888"><br>
Richard<br>
</font></span></blockquote></div><br></div>