<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">Le 12/12/2024 à 16:33, Julien Cabieces
via QGIS-Developer a écrit :<br>
</div>
<blockquote type="cite" cite="mid:874j387w69.fsf@julienlaptop.home">
<pre class="moz-quote-pre" wrap="">
Not a great fan of this approach, It looks like complicated to me, I would prefer the old behavior.
Those automatic PR force also contributor to rebase before pushing new
modification to their branch. And if they have modified area of code
which have been reformatted, they get conflicts.
automatic pre-commit commits brings more difficulties than what it
solves IMHO.</pre>
</blockquote>
<p>I also tend to agree on that. On other projects I'm involved too
(GDAL, PROJ, shapelib, libtiff) where we have put in place
pre-commit, we just have a CI check that checks the formatting is
OK. This requires a bit of education to first time contributors,
but pointing to the documentation with clear instructions on how
to setup pre-commit should be good enough.
<a class="moz-txt-link-freetext" href="https://github.com/qgis/QGIS/edit/master/.github/PULL_REQUEST_TEMPLATE.md">https://github.com/qgis/QGIS/edit/master/.github/PULL_REQUEST_TEMPLATE.md</a>
could also have some words about it</p>
<p>Like in
<a class="moz-txt-link-freetext" href="https://github.com/OSGeo/gdal/edit/master/.github/PULL_REQUEST_TEMPLATE.md">https://github.com/OSGeo/gdal/edit/master/.github/PULL_REQUEST_TEMPLATE.md</a>
, " - [ ] Make sure code is correctly formatted (cf [pre-commit
configuration](<a class="moz-txt-link-freetext" href="https://gdal.org/development/dev_practices.html#commit-hooks">https://gdal.org/development/dev_practices.html#commit-hooks</a>))"</p>
<span style="white-space: pre-wrap">
</span>
<pre class="moz-signature" cols="72">--
<a class="moz-txt-link-freetext" href="http://www.spatialys.com">http://www.spatialys.com</a>
My software is free, but my time generally not.
Butcher of all kinds of standards, open or closed formats. At the end, this is just about bytes.</pre>
</body>
</html>