[Qgis-psc] Motion: git write access for Etienne Tourigny

Martin Dobias wonder.sk at gmail.com
Wed Jul 11 04:23:33 PDT 2012


On Wed, Jul 11, 2012 at 11:15 AM, Tim Sutton <tim at linfiniti.com> wrote:
> Hi
>
> On Wed, Jul 11, 2012 at 4:07 AM, Etienne Tourigny
> <etourigny.dev at gmail.com> wrote:
>> Thanks all
>>
>> I will start by committing a slightly modified version of my histogram
>> improvements (in a pull request).
>>
>> Speaking of tests - any idea how the histogram could be tested, and if
>> it's worth it?
>
> Ideal would be to move histogram logic down into the gui lib as we
> don't yet have a test system in place for app. I could envisage a nice
> call like:
>
> QSize mySize(800,400);
> QImage myImage = myRasterLayer ->histogramImage(mySize);
>
> I don't know if that will make sense though given that you are adding
> interactivity to the widget....

Or simply have a HistogramGraph class in core lib - that would take
care of bare histogram drawing (to any paint device) - and
HistogramGraphWidget in gui lib that would take care of interactivity
and would make use of HistogramGraph.

(and welcome to the team, Etienne!)

Cheers
Martin



More information about the Qgis-psc mailing list