[Qgis-psc] [QGIS-Developer] Direct push forbidden to master

Nyall Dawson nyall.dawson at gmail.com
Fri Nov 8 01:32:06 PST 2019


On Fri, 8 Nov 2019 at 18:33, ElPaso <elpaso at itopen.it> wrote:

> I'm with Jürgen on this, I think we all are responsible developers
> acting for the good of QGIS and I didn't see any abuse on direct commits
> in the past few years.
>
>
> On the contrary, I think I should have committed to master directly to
> correct a PR of mines that I merged by mistake the day before 3.10
> release (https://github.com/qgis/QGIS/pull/32369) instead of waiting for
> an approval that didn't arrive in time (in this case it wasn't really a
> big problem though).

I don't think Denis is arguing for forced-reviews of pull requests.
Rather just that all changes GO through pull requests so that we can
be sure they don't break CI.

Nyall

>
>
> Cheers
>
>
> --
> Alessandro Pasotti
> w3: www.itopen.it
>
> _______________________________________________
> Qgis-psc mailing list
> Qgis-psc at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/qgis-psc



More information about the Qgis-psc mailing list