[Qgis-psc] [qgis/QGIS-Enhancement-Proposals] Support SAP HANA databases in QGIS (#151)

[Tim Sutton]

Hi (replying to both Even and Nyall here)...


> On 4 Sep 2019, at 09:32, Even Rouault <even.rouault at spatialys.com> wrote:
> 
> On mercredi 4 septembre 2019 17:32:46 CEST Nyall Dawson wrote:
>> On Wed, 4 Sep 2019 at 17:20, Tim Sutton <tim at kartoza.com> wrote:
>>> Testing platform: Currently it is difficult for us to test the work you
>>> have done since we do not have a test / sandbox instance of the provider
>>> that we can use to try it out. Could we ask you to provide us with a
>>> perpetually available Hana database instance that we can use to test your
>>> provider both now and in the future? It would be ideal if you could set
>>> up and maintain this instance for us and simply supply the connection
>>> details since we do not have the time or expertise to manage this from
>>> within the community. We also ask that you waive any licensing fees for
>>> this test platform so that it is freely available to the project.
>> Could you add here that it needs to be accessible via our CI
>> infrastructure, and that they'll need to include unit tests
>> implementing the provider conformance suite which run on our CI ?
>> 
>> Without this I will strongly and vocally oppose this work, because
>> it's effectively asking to be broken.

@Nyall we discussed this a bit in Bucharest. There are a few concerns - figuring out how to reasonably manage testing infrastructure as Even touches on below being one, the lack of any clear directive mandating tests (I think we should add something to our contributor guidelines), the lack of any precedent test suite (previously we only mandated libqgiscore tests) being another. Personally I wonder if we shouldn’t be thinking more broadly and have a generic test suite that works with all providers to validate general CRUD operations? Since we have a common API for providers this should be possible right?


> 
> yeah, "any untested code is broken code"
> 
> But I think they'll have a hard time communicating a public connection string 
> to their database as this could be abused by anybody. I was going to suggest 
> we could probably keep it as a Travis-CI encrypted string, but encrypted 
> strings don't work with pull requests. And even if it did, any QGIS developer 
> requesting it should also have access to it when needed. Tests against a 
> shared instance should also be carefuly written so that if 2 persons by chance 
> run the test at the same time, there's no conflict on table names that are 
> created or whatever at runtime.
> 
> If they have a Docker image, lightweight enough and with all setup done (it's 
> fine if it has limitations on database size, etc if they don't want this to be 
> abused for production use), that could also be a reasonable solution for both 
> Travis & local testing. Except that wouldn't work for Mac or Windows devs…

@Even yeah it seems there is one here:

https://developers.sap.com/tutorials/hxe-ua-install-using-docker.html

Do I remember correctly from watching your GDAL summary at FOSS4G that there was also a HANA provider added in GDAL? How have you implemented tests in your situation?

If we are going to test in docker we can just spin up a HANA image in the local docker network where the tests execute and have hardcoded connection details in the test suite since it would not be publicly accessible and live only as long as the test run lives.

@nyall By the way there were quite a few people commenting on the test suite in QGIS that we should probably discuss at some point. We can pick up on that in a separate thread later.

Regards

Tim

> 
> Cheers,
> 
> Even
> 
> -- 
> Spatialys - Geospatial professional services
> http://www.spatialys.com <http://www.spatialys.com/>
> _______________________________________________
> Qgis-psc mailing list
> Qgis-psc at lists.osgeo.org <mailto:Qgis-psc at lists.osgeo.org>
> https://lists.osgeo.org/mailman/listinfo/qgis-psc <https://lists.osgeo.org/mailman/listinfo/qgis-psc>
 




---

Tim Sutton
tim at qgis.org




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-psc/attachments/20190905/9c161963/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qgis-icon-60x60.png
Type: image/png
Size: 4401 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/qgis-psc/attachments/20190905/9c161963/attachment.png>