[QGIS-trac] Re: [Quantum GIS] #515: Thoroughly use OGR

[Quantum GIS]

#515: Thoroughly use OGR
----------------------------------------------------+-----------------------
        Reporter:  bertelli                         |         Owner:  timlinux     
            Type:  enhancement                      |        Status:  assigned     
        Priority:  minor: annoyance or enhancement  |     Milestone:  Version 2.0.0
       Component:  OGR Layer support                |       Version:  HEAD         
      Resolution:                                   |      Keywords:               
Platform_version:                                   |      Platform:  All          
        Must_fix:  No                               |   Status_info:  0            
----------------------------------------------------+-----------------------
Changes (by timlinux):

  * status:  new => assigned
  * owner:  gcontreras => timlinux

Comment:

 Hi Godofredo

 I tested your patch here. The dialog has some layout issues making the
 upper frame impossible to see here on Ubuntu. I can fix this for you. Also
 the encoding selector has gone from the open dialog which may cause people
 in some locales issues - is there a way to reinstate that?

 Also note that for sake of clarity, new methods added to the 1.x api
 should state which version they were added

 {{{
      virtual QString fileVectorFilters() const;
 +    /** return a string containing the available database drivers */
 +       virtual QString databaseDrivers() const;
 +       /** return a string containing the available directory drivers */
 +    virtual QString directoryDrivers() const;
 +       /** return a string containing the available protocol drivers */
 +    virtual QString protocolDrivers() const;
 }}}

 Should have comments added like:

 {{{
 /** return a string containing the available protocol drivers
   * @note this method was added in QGIS 1.1
 */
 }}}

 so that it is obvious to programmers when they will be deviating from the
 stable supported 1.0.x api.

 I am really looking forward to the new functionality introduced by your
 patch making its way into SVN!


 Regards

 Tim

-- 
Ticket URL: <https://trac.osgeo.org/qgis/ticket/515#comment:5>
Quantum GIS <http://qgis.org>
Quantum GIS is an Open Source GIS viewer/editor supporting OGR, PostGIS, and GRASS formats