[QGIS-trac] Re: [Quantum GIS] #2634: Spatial Query Plugin source for avaliation

[Quantum GIS]

#2634: Spatial Query Plugin source for avaliation
--------------------------------------------------------------+-------------
        Reporter:  lmotta                                     |         Owner:  timlinux     
            Type:  patch                                      |        Status:  new          
        Priority:  critical: causes crash or data corruption  |     Milestone:  Version 1.5.0
       Component:  C++ Plugins                                |       Version:  HEAD         
      Resolution:                                             |      Keywords:  Spatial Query
Platform_version:                                             |      Platform:  Debian       
        Must_fix:  No                                         |   Status_info:  0            
--------------------------------------------------------------+-------------
Comment (by timlinux):

 Adding spatialindex dir fixed it:

 {{{
  39 INCLUDE_DIRECTORIES(
  40      ${CMAKE_CURRENT_BINARY_DIR}
  41      ${CMAKE_CURRENT_BINARY_DIR}/../../ui/
  42      ../../core
  43      ../../core/spatialindex
  44      ../../core/raster
  45      ../../core/renderer
  46      ../../core/symbology
  47      ../../gui
  48      ..
  49 )
 }}}

 Having built and tested the plugin (works great!) my feedback is this:

 a) I think we should put it in the main gui rather than as a plugin.
 b) I would remove the status on the side and botton and just have the
 selection operators and a progress bar. Or at the very least hide that
 stuff away with an 'advanced button' since the output there is more of
 interest to developers of the plugin that for general users.
 c) The user interface is not HIG compliant:
    - the combos have a squashed vertically look so they are not sizing
 right
    - labels should be upper case for first letter only thereafter all
 lower case
    - labels and widgets should have buddies set.

 Regardless of whether it is added as a plugin or in gui if they above
 issues are resolved it would be +1 from me for inclusion into 1.5 - nice
 work!

 Tim

-- 
Ticket URL: <http://trac.osgeo.org/qgis/ticket/2634#comment:2>
Quantum GIS <http://qgis.org>
Quantum GIS is an Open Source GIS viewer/editor supporting OGR, PostGIS, and GRASS formats