[QGIS-trac] Re: [Quantum GIS] #3430: fill pattern missing for point markers in new symbology engine

[Quantum GIS]

#3430: fill pattern missing for point markers in new symbology engine
------------------------------------------------+---------------------------
   Reporter:  nirvn                             |              Owner:  sunilkcube   
       Type:  patch                             |             Status:  assigned     
   Priority:  major: does not work as expected  |          Milestone:  Version 1.7.0
  Component:  Symbology                         |            Version:  Trunk        
   Keywords:                                    |   Platform_version:               
   Platform:  All                               |           Must_fix:  No           
Status_info:  0                                 |  
------------------------------------------------+---------------------------

Comment(by Alister):

 Ah - there's a preview button!  I should use it ;)
 -----------
 >- fill style is not applied to selected features (actually, it looks like
 selected points are rendered by simply filling each symbol layer with
 yellow, so if transparency is applied the yellow is darker where two
 symbol layers overlap). I don't think this is a significant problem.

 >-  transparency is only applied to borders, not fills.

 OK, that was easier than I expected. I've had a look at it, and fixed
 those things, and also what I'm pretty sure was a pre-existing mistake in
 this line:

 {{{
 QColor selPenColor = selBrushColor == mColor ? selBrushColor :
 mBorderColor;
 }}}

 I had to tidy/rearrange that section of code so I could understand it :)

 I added a number of comments, mostly about inconsistencies compared with
 how QGIS renders polygon layers. Can someone else look at these and tell
 me what they think?

 There is one reasonably annoying bug:

 {{{
 //"no fill" doesn't work if brushColor = penColor
 // e.g. if the symbol is a circle, the whole bounding box (is that what
 it's called?)
 // of the circle is filled.
 }}}

 I'm guessing to fix this an if statement is required something like the
 one I commented out because that method didn't work. But I don't know what
 to put in it!

-- 
Ticket URL: <http://trac.osgeo.org/qgis/ticket/3430#comment:17>
Quantum GIS <http://qgis.org>
Quantum GIS is an Open Source GIS supporting GDAL/OGR, PostGIS, and GRASS formats, and Web Services