[QGIS-trac] Re: [Quantum GIS] #3430: fill pattern missing for point markers in new symbology engine

[Quantum GIS]

#3430: fill pattern missing for point markers in new symbology engine
------------------------------------------------+---------------------------
   Reporter:  nirvn                             |              Owner:  sunilkcube   
       Type:  patch                             |             Status:  assigned     
   Priority:  major: does not work as expected  |          Milestone:  Version 1.7.0
  Component:  Symbology                         |            Version:  Trunk        
   Keywords:                                    |   Platform_version:               
   Platform:  All                               |           Must_fix:  No           
Status_info:  0                                 |  
------------------------------------------------+---------------------------

Comment(by Alister):

 Oh, and I think I was wrong about this:

 {{{
 // Alister - I don't understand the reasoning for the following line
 //  QColor selPenColor = selBrushColor == mColor ? selBrushColor :
 mBorderColor;
 // I think it is a mistake and is meant to be this
   QColor selPenColor = mBorderColor == mColor ? selBrushColor :
 mBorderColor ;
 }}}

 This wouldn't have been a mistake - it is trying to make the selection
 look different if the symbol fill is the same colour as the selection
 fill.  But there are still things that could be improved here: it won't
 achieve anything if the symbol fill and the symbol outline are ''both''
 the same colour as the selection fill.  Also, polygon layers aren't dealt
 with in the same way, and they probably should be.

-- 
Ticket URL: <http://trac.osgeo.org/qgis/ticket/3430#comment:21>
Quantum GIS <http://qgis.org>
Quantum GIS is an Open Source GIS supporting GDAL/OGR, PostGIS, and GRASS formats, and Web Services