[Qgis-user] Browser Panel Import

[Alessandro Pasotti]

On Tue, Sep 5, 2017 at 9:14 AM, Richard Duivenvoorde <rdmailings at duif.net>
wrote:

>
> While it's nice to impress new users to use this 'drag a file into a
> database' feature :-) .... I think it's also a 'shoot and run' solution:
> either OK or nothing...
>
> Would it be an idea to (sorry dialog haters) have a summary/confirmation
> dialog in between this action? Telling the user that 'this file/table
> with such columns be copied/moved to that file/table with these columns'?
>
> In this case, it would also have made it possible to stop this overwrite
> action?
>

I don't think it's a good design: if the result of the action is reversible
a confirm dialog is unnecessary, and we are trying to elminate all
unnecessary modals.
I'd stick to the confirm dialog for all potentially destructive actions.

I recommend to follow the new geopackage implementation behavior:
- if the drop is on self: abort
- if the drop overrides an existing table: confirm
- if the drop does not override and hence creates a new table: notify on
success or error

If you've done a wrong drop, you can easily delete the imported layer (at
least now it's implemented for geopackage and all ogr/gdal, provided it's
supported by the gdal/ogr provider)

Regards.



>
> Regards,
>
> Richard Duivenvoorde
>
> On 05-09-17 09:04, Alessandro Pasotti wrote:
> > It looks like a bug.
> >
> > Did you file a ticket?
> >
> > The expected behavior is that the layer you are dragging is imported
> > (without overwriting!) into the destination DB (the drop target).
> >
> > In case of overwriting, a confirm dialog should appear.
> >
> > I've recently worked on that for geopackage and I've also added some
> > logic to prevent dropping onto itself (that could lead to data loss).
> >
> > Cheers
> >
> >
> >
> > On Tue, Sep 5, 2017 at 8:39 AM, Martin Bain
> > <Martin.Bain at lismore.nsw.gov.au <mailto:Martin.Bain at lismore.nsw.gov.au>>
> > wrote:
> >
> >     Hi List,____
> >
> >     I just discovered a brutal feature of the Browser Panel.____
> >
> >     __ __
> >
> >     When browsing SQL Server if you happen to click and drag on a table
> >     then when you release the mouse button a dialog box will pop up
> >     saying “Import Competed”.____
> >
> >     __ __
> >
> >     The table under the cursor when mouse button is released gets
> >     overwritten with an empty table, without any sort of prompt!____
> >
> >     __ __
> >
> >     Within SQL Server I have now revoked DDL permissions from the user
> >     that did this (and myself).____
> >
> >     __ __
> >
> >     But was wondering, Is there a way to prevent or modify this
> >     behaviour in QGIS?____
> >
> >     __ __
> >
> >     Thanks,____
> >
> >     Martin.____
> >
> >
> >     This email is intended for the named recipient only. The information
> >     it contains may be confidential. If you are not the intended
> >     recipient you must not reproduce or distribute any part of this
> >     email, disclose its contents to any other party or take any action
> >     in reliance on it. If you have received this email in error, please
> >     contact the sender immediately and delete the message.
> >
> >     _______________________________________________
> >     Qgis-user mailing list
> >     Qgis-user at lists.osgeo.org <mailto:Qgis-user at lists.osgeo.org>
> >     List info: https://lists.osgeo.org/mailman/listinfo/qgis-user
> >     <https://lists.osgeo.org/mailman/listinfo/qgis-user>
> >     Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-user
> >     <https://lists.osgeo.org/mailman/listinfo/qgis-user>
> >
> >
> >
> >
> > --
> > Alessandro Pasotti
> > w3:   www.itopen.it <http://www.itopen.it>
> >
> >
> > _______________________________________________
> > Qgis-user mailing list
> > Qgis-user at lists.osgeo.org
> > List info: https://lists.osgeo.org/mailman/listinfo/qgis-user
> > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-user
> >
>
>


-- 
Alessandro Pasotti
w3:   www.itopen.it
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-user/attachments/20170905/00ff919a/attachment.html>