<div dir="ltr"><div><div><div><div><div>Hi,<br><br></div>in QGIS 3 the source select dialogs have been deeply refactored and they now use a base class for a better consistency among different providers. <br></div><div>Buttons [Close, Add] should be the same in all dialogs, some specific providers may add other buttons.<br><br></div>There has been a lot of discussion about the buttons: initial implementation had [Add, Ok, Close] where Add=Apply, Ok=Apply+Close and Close=Cancel (it was just closing the dialog).<br><br></div>Now we agreed on dropping the 'Ok' and leave [Close, Add, Help].<br><br></div>Now about the order, that should be controlled by Qt and it should be platform-dependent following the O.S. guidelines: see <a href="http://doc.qt.io/qt-5/qdialogbuttonbox.html">http://doc.qt.io/qt-5/qdialogbuttonbox.html</a> and, for windows, <a href="https://msdn.microsoft.com/en-us/library/windows/desktop/bb246415(v=vs.85).aspx">https://msdn.microsoft.com/en-us/library/windows/desktop/bb246415(v=vs.85).aspx</a><br><br></div>That said, there is probably room for improvement by moving the [Close, Add] buttons from the class to the UI file so that the Qt ordering is honored (I suspect that by adding those buttons in the class instead of in the UI it is not).<br><div><div><br></div><div>So, yes, please file a ticket and assign it to me so I don't forget to look at that.<br></div><div><div><br><div><br></div></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 19, 2017 at 5:59 PM, McDonaldR <span dir="ltr"><<a href="mailto:McDonaldR@angus.gov.uk" target="_blank">McDonaldR@angus.gov.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div link="blue" vlink="purple" lang="EN-GB">
<div class="m_-4655434809457073702WordSection1">
<p class="MsoNormal">Hi List,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">I’m running QGIS 2.18.12 and latest 2.99 on Windows 7. I have a question about the order of the buttons in the dialogue boxes on the Manage Layers toolbar. Maybe it’s my OCD and maybe others have a similar issue…<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span><img id="m_-4655434809457073702Picture_x0020_1" src="cid:image001.png@01D378E8.53205510" height="99" width="485"></span><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="m_-4655434809457073702MsoListParagraph"><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>The Add Spatialite dialogue has Add | (Set Filter) | (Update Statistics) | Close | Help<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="m_-4655434809457073702MsoListParagraph"><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>The Add WCS dialogue has Close | Add | Help<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="m_-4655434809457073702MsoListParagraph"><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>The Add WMS dialogue has Add | Close | Help **<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="m_-4655434809457073702MsoListParagraph"><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>The Add Database Layer dialogue has Add | Set Filter | Close | Help<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">To me the order of Add | Close | Help makes sense and the order of the buttons on the WCS dialogue** is a minor bug.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">In the latest master 2.99 the buttons on the Add Data dialogue boxes have all been switched to be
<b>Close</b> | <b>Add</b> | <b>Help</b> with the <b>Add</b> button disabled until a layer has been selected. Now I don’t know if it is just me but I am used to using buttons that have the “positive” action of
<b>Add</b> or <b>OK</b> first and then the “negative” action of <b>Close</b> or <b>
Cancel</b> next (to the right) and then <b>Help</b> (if required).<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span><img id="m_-4655434809457073702Picture_x0020_2" src="cid:image002.png@01D378EA.BE597350" height="86" width="401"></span><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Maybe I just need to be retrained to click the next button to the right but at the moment it just feels wrong as I keep clicking Close instead of Add. Anyone else? Is it a feature request to have the button order changed or a minor bug?<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thanks<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Ross<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Century Gothic","sans-serif";color:#4f6228">Ross McDonald |
</span></b><span style="font-size:10.0pt;font-family:"Century Gothic","sans-serif";color:#4f6228">GIS Data Coordinator | Angus Council, People, IT | Angus House, Orchardbank Business Park, Sylvie Way, Forfar DD8 1AT<b> | t: 01307
476419<u></u><u></u></b></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div> </div>
<div>
<p class="MsoNormal" style="MARGIN:0cm 0cm 0pt"><span style="FONT-SIZE:7.5pt;FONT-FAMILY:'Arial','sans-serif'"><font size="2">This message is strictly confidential. If you have received
this in error, please inform the sender and remove it from your system. If received in error you may not copy, print, forward or use it or any attachment in any way. This message is not capable of creating a legal contract or a binding representation and does
not represent the views of Angus Council. Emails may be monitored for security and network management reasons.<span>
</span>Messages containing inappropriate content may be intercepted. Angus Council does not accept any liability for any harm that may be caused to the recipient system or data on it by this message or any attachment.
</font></span></p>
</div>
</div>
<br>______________________________<wbr>_________________<br>
Qgis-user mailing list<br>
<a href="mailto:Qgis-user@lists.osgeo.org">Qgis-user@lists.osgeo.org</a><br>
List info: <a href="https://lists.osgeo.org/mailman/listinfo/qgis-user" rel="noreferrer" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/qgis-user</a><br>
Unsubscribe: <a href="https://lists.osgeo.org/mailman/listinfo/qgis-user" rel="noreferrer" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/qgis-user</a><br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Alessandro Pasotti<br>w3: <a href="http://www.itopen.it" target="_blank">www.itopen.it</a></div>
</div>