[fusion-dev] [Code Review]Theme widget cause an error on raster layer

[Arthur Liu]

Hi all,

Would you please review the patch at http://trac.osgeo.org/fusion/attachment/ticket/359/thememain.patch for ticket http://trac.osgeo.org/fusion/ticket/359?

Comments:
Theme widget doesn't work on raster and drawing layers(if I am right), but it should not throw error like http://trac.osgeo.org/fusion/attachment/ticket/359/Raster.JPG

[Analysis]
For layers which don't contain the geometry property, the layer's name will not be record in layerNames in theme.php
So in thememain.php the layerSelect.value will be null, and the layerInfo request will fail.


[Resolution/Workaround]
To resolve this problem, I checked the layerSelect.value, if it's null, just return.

Thanks,
Arthur

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osgeo.org/pipermail/fusion-dev/attachments/20100207/021b5528/attachment.html