[fusion-dev] Please review the patch: enhance the MapTip widget to enable/disable map tooltips

[Michael Adair]

Hi Buddy,

I have a couple of comments on this:

1. the default behaviour should remain the same as before applying this 
patch which is to be enabled without a button.  To me it looks like you 
are changing this widget to always require a button to enable the 
tooltips, which will break a lot of existing applications that don't 
have a spot for the button.   You need to make the button an optional 
behaviour.

2. calculating this.mainPath: we already have Fusion.fusionURL which 
holds a pointer to where fusion.js was loaded from and your images 
should be relative to that or relative to the template directory.  The 
way you are getting that image URL just looks odd to me and not the 
usual Fusion way of doing things.

Cheers,

Mike


On 29/07/2011 5:35 AM, Buddy Hu wrote:
>
> Hi List,
>
> Please help to review the patch: https://trac.osgeo.org/fusion/ticket/471
>
> This patch intends to enhance the "MapTip" widget, makes this widget 
> to be a UI widget(a button), so that the users can press it to 
> enable/disable the map tooltips.
>
> The motivation of this enhancement is to provide an opportunity for 
> the users to reduce the overload of Server by disable the map tooltips.
>
> Thanks in advance!
>
> Buddy
>
>
>
> _______________________________________________
> fusion-dev mailing list
> fusion-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/fusion-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osgeo.org/pipermail/fusion-dev/attachments/20110729/0af7b63a/attachment.html