[geotk] datum shift missing

[Dieter Stüken]

Hi Martin,

great, now it works as expected! Thanks for the quick response.

Currently I work with SNAPSHOT releases. We project a new release for next year.
Do you have a rough estimation when some snapshots or releases will be reached again?

I still depend on a few helper classes from GeoTk (like DefaultCoordinateOperationFactory), but may be those will move to SIS someday, too. Finally I prefer to depend on SIS only which looks much smarter for me.

Dieter.

From: geotoolkit-bounces at lists.osgeo.org [mailto:geotoolkit-bounces at lists.osgeo.org] On Behalf Of Martin Desruisseaux
Sent: Freitag, 5. September 2014 14:57
To: geotoolkit at lists.osgeo.org
Subject: Re: [geotk] datum shift missing

Hello Dieter

Very good catch, I own you my congratulation! (as it was deep in the code). This bug has been introduced when we migrated from javax.vecmath matrices to the Apache SIS matrices. Vecmath performed the multiplication in-place (overwriting the source matrix) while SIS returns the result in a new matrix. In the migration to SIS, we forgot to assign the result in this particular place.

I just fixed the bug and pushed the fix to GitHub. Would you have a chance to test again?

On the code accuracy, the testing effort has shifted to Apache SIS. Some Geotk tests have been ignored because I was planning to review them in depth when those parts will migrate to SIS (SIS has a more reproductive testing environment with better diagnostics in case of failure).

My apologize for the inconvenience...

    Martin


Le 05/09/14 14:13, Dieter Stüken a écrit :
Hi,

I participate on developing some frequency-analysis software tool (Java) for about ten years now:
http://www.irt.de/en/activities/programme-distribution/frequency-planning-software.html

We have a lot of legacy code on board, but we also try to introduce advanced technologies.
We switched to Java8 already and started using JavaFX  instead of Swing, since it is (still) a desktop application....

I observe the development of Geotk and SIS since a year, and the transition to SIS has many ideas in common with our current approach.
So my first try was to use the referencing module to replace our internal coordinate transformations.
Our current implementation depends on a very old geotoolkit version I want to get rid of.

Since we use only a small set of CRs (about 5-6) those are hardcoded and I don't like to involve the full EPSG database.
Unfortunately I did not get the datum shift working.

I tracked it down to where the transformation matrices are build and ended up here:

https://github.com/Geomatys/geotoolkit/blob/master/modules/referencing/geotk-referencing/src/main/java/org/geotoolkit/referencing/operation/DefaultCoordinateOperationFactory.java#L1080

which performs the concatenation but finally does not use the result matrix returned :(

I even found a unit test for this:

https://github.com/Geomatys/geotoolkit/blob/master/modules/referencing/geotk-referencing/src/test/java/org/geotoolkit/referencing/operation/COFactoryUsingMolodenskyTest.java#L451

but unfortunately it is @Ignored.

Do I miss something?

Dieter.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geotoolkit/attachments/20140905/6a097989/attachment-0001.html>